Message-ID: <dc67fb77-fc83-dc69-e171-0c8fbdd22191@postgresfriends.org>
Date: Fri, 30 Sep 2022 17:58:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: Tracking last scan time
Content-Language: en-US
To: Dave Page <dpage@pgadmin.org>, Andres Freund <andres@anarazel.de>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>,
 PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
References: 
 <CA+OCxozrVHNFVEPkweUHMZje+t1tfY816d9MZYc6eZwOOusOaQ@mail.gmail.com>
 <20220831162108.qyarvx7edqnobiye@awork3.anarazel.de>
 <CAEze2WiSvToc1bz2OGz+614COShD5H1Z+NLDSwORfT3p975qgA@mail.gmail.com>
 <20220831185629.mrr2jlwjubsy2pvi@awork3.anarazel.de>
 <CAEze2Whn3UG0RHYGXtKfN9BX9m3F53Fh813_FByhC2XF1DErvQ@mail.gmail.com>
 <20220901183540.cyfje2lsiouj4qi4@awork3.anarazel.de>
 <CA+OCxoxkuMF+hkVWDkiQWnjNpjeap=mYMkHzsdSvFxjjBocrZg@mail.gmail.com>
 <20220906155325.an3xesq5o3fq36gt@awork3.anarazel.de>
 <CA+OCxowT==feMvVbDaHyTKvcCp8JAHHW1khHCafa-VG3xrhZ1A@mail.gmail.com>
From: Vik Fearing <vik@postgresfriends.org>
In-Reply-To: 
 <CA+OCxowT==feMvVbDaHyTKvcCp8JAHHW1khHCafa-VG3xrhZ1A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/dc67fb77-fc83-dc69-e171-0c8fbdd22191%40postgresfriends.org>
Precedence: bulk

On 9/7/22 12:03, Dave Page wrote:
> Here's a v4 patch. This reverts to using
> GetCurrentTransactionStopTimestamp() for the last_scan times, and will
> set xactStopTimestamp the first time GetCurrentTransactionStopTimestamp()
> is called, thus avoiding multiple gettimeofday() calls.
> SetCurrentTransactionStopTimestamp() is removed, as is use
> of xactStopTimestamp (except when resetting it to 0).

This patch looks good to me and has much saner behavior than what it 
replaces.

As a matter of process, the oid for the new function should be in the 
8000-9000 range and the catversion should be bumped by the committer.

Marked as Ready for Committer.  Thanks for the patch!
-- 
Vik Fearing