Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLgYe-00061e-6x for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Sep 2020 05:46:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kLgYc-0007mP-6c for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Sep 2020 05:46:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLgYc-0007mI-03 for pgsql-hackers@lists.postgresql.org; Fri, 25 Sep 2020 05:46:10 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLgYX-00047Y-1q for pgsql-hackers@postgresql.org; Fri, 25 Sep 2020 05:46:09 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTP id 09AC9602E8; Fri, 25 Sep 2020 14:46:01 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 25 Sep 2020 14:46:00 +0900 From: Katsuragi Yuta To: legrand legrand Cc: pgsql-hackers@postgresql.org Subject: Re: [PATCH] Add features to pg_stat_statements In-Reply-To: <1600941306200-0.post@n3.nabble.com> References: <0d9f1107772cf5c3f954e985464c7298@oss.nttdata.com> <1600500942767-0.post@n3.nabble.com> <16a262a87492b4f4afc4c5010f8fa631@oss.nttdata.com> <1600924523318-0.post@n3.nabble.com> <1600941306200-0.post@n3.nabble.com> Message-ID: X-Sender: btkatsuragiyu@oss.nttdata.com User-Agent: Roundcube Webmail/1.1.9 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-09-24 18:55, legrand legrand wrote: > Not limited to 3, Like an history table. > > Will have to think if data is saved at shutdown. Thanks. This design might introduce some additional complexity and things to be considered. For example, the maximum size of "history table", how to evict entries from the history table and how to manage the information maintained by evicted entries. Also, providing a history table looks similar to logging. Providing the original view (# of dealloc and last_dealloc ts) and optional logging looks a simple and better way. Regards, Katsuragi Yuta