public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Zhang <[email protected]>
To: Jim Jones <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] Add inline comments to the pg_hba_file_rules view
Date: Fri, 8 Sep 2023 16:52:03 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

This is a very useful feature. I applied the patch to the master branch, 
and both make check and make check-world passed without any issues.

Just one comment here, based on the example below,

> host db jim 127.0.0.1/32 md5 #     #foo#
>
> ... it returns the following pg_hba_file_rules records:
>
> postgres=#  SELECT type, database, user_name, address, comment
>  FROM pg_hba_file_rules
>  WHERE user_name[1]='jim';
>
>  type | database | user_name |  address  | comment
> ------+----------+-----------+-----------+---------
>  host | {db}     | {jim}     | 127.0.0.1 | #foo#

Since "only the first #" and "any leading spaces" are removed, IMO, it 
can be more accurate to say,

Text after the first <literal>#</literal> comment character in the end 
of a valid <literal>pg_hba.conf</literal> entry, if any


Best regards,

David

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Add inline comments to the pg_hba_file_rules view
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox