Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJvgA-0007vR-IQ for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jan 2023 12:12:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pJvg9-00064R-D7 for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jan 2023 12:12:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJvg9-00064I-3w for pgsql-hackers@lists.postgresql.org; Mon, 23 Jan 2023 12:12:01 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJvg6-0001Qj-JK for pgsql-hackers@lists.postgresql.org; Mon, 23 Jan 2023 12:12:00 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 22B3040003; Mon, 23 Jan 2023 12:11:54 +0000 (UTC) Message-ID: Date: Mon, 23 Jan 2023 07:11:53 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: run pgindent on a regular basis / scripted manner Content-Language: en-US To: Tom Lane Cc: pgsql-hackers@lists.postgresql.org References: <20200814202651.GA31108@alvherre.pgsql> <531251.1674234545@sss.pgh.pa.us> <20230120175806.iogdcra2xpmmh5de@awork3.anarazel.de> <538672.1674238787@sss.pgh.pa.us> <17455b0f-0161-9aa9-b6dd-1279e947b8f4@dunslane.net> <3cdb09f1-6375-4198-e8c1-e33ca4c96304@dunslane.net> <912484.1674317408@sss.pgh.pa.us> <55588553-a433-96ec-fdfe-fd46ac6f3a4a@dunslane.net> <1217035.1674404309@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: <1217035.1674404309@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-01-22 Su 11:18, Tom Lane wrote: > Andrew Dunstan writes: >>> ... btw, can we get away with making the diff run be "diff -upd" >>> not just "diff -u"? I find diff output for C files noticeably >>> more useful with those options, but I'm unsure about their >>> portability. >> I think they are available on Linux, MacOS and FBSD, and on Windows (if >> anyone's actually using it for this) it's likely to be Gnu diff. So I >> think that's probably enough coverage. > I checked NetBSD as well, and it has all three too. > > Patch looks good to me. > > Thanks, pushed. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com