Content-Type: text/plain; charset="iso-8859-15"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: Unicode normalization SQL functions
From: "Daniel Verite" <daniel@manitou-mail.org>
To: "Peter Eisentraut" <peter.eisentraut@2ndquadrant.com>
Cc: "Andreas Karlsson" <andreas@proxel.se>,"pgsql-hackers"
 <pgsql-hackers@postgresql.org>
In-Reply-To: <bba8933e-44ef-761d-55fb-076f2b6b5650@2ndquadrant.com>
Date: Mon, 17 Feb 2020 20:14:03 +0100
Message-Id: <dd16d2c4-e7cb-4e6d-a92d-40e8dc1cf8a6@manitou-mail.org>
Precedence: bulk

 One nitpick:

Around this hunk:

- * unicode_normalize_kc - Normalize a Unicode string to NFKC form.
+ * unicode_normalize - Normalize a Unicode string to the specified form.
  *
  * The input is a 0-terminated array of codepoints.
  *
@@ -304,8 +306,10 @@ decompose_code(pg_wchar code, pg_wchar **result, int
*current)
  * string is palloc'd instead, and OOM is reported with ereport().
  */


The comment in full says:

/*=09=09=09=09=09=09=09=09=09=20=20=20=20=20=20
 * unicode_normalize - Normalize a Unicode string to the specified form.=20=
=20=20=20=20=20
 *=09=09=09=09=09=09=09=09=09=20=20=20=20=20=20
 * The input is a 0-terminated array of codepoints.=09=09=09=20=20=20=20=20=
=20
 *=09=09=09=09=09=09=09=09=09=20=20=20=20=20=20
 * In frontend, returns a 0-terminated array of codepoints, allocated with=
=20=20=20=20
 * malloc. Or NULL if we run out of memory. In frontend, the returned=09=20=
=20=20=20=20=20
 * string is palloc'd instead, and OOM is reported with ereport().=09=20=20=
=20=20=20=20
 */

It looks like the 2nd occurrence of "frontend" was meant to be "backend".


Best regards,
--=20
Daniel V=E9rit=E9
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite