Message-ID: <dd53c632abf86fc6dacf6653f9fbab9110ccdc14.camel@j-davis.com>
Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX
From: Jeff Davis <pgsql@j-davis.com>
To: Nathan Bossart <nathandbossart@gmail.com>, Michael Paquier
	 <michael@paquier.xyz>
Cc: Ted Yu <yuzhihong@gmail.com>, Pavel Luzanov <p.luzanov@postgrespro.ru>, 
	Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Date: Tue, 20 Jun 2023 10:04:37 -0700
In-Reply-To: <20230619215534.GA442477@nathanxps13>
References: <20230113225626.GA2380176@nathanxps13>
	 <20230113231339.GA2422750@nathanxps13>
	 <20230613211246.GA219055@nathanxps13> <ZIj4v1CwqlDVJZfB@paquier.xyz>
	 <20230613235442.GA222795@nathanxps13> <20230614181711.GA488295@nathanxps13>
	 <ZIpfack6qJUHaw+g@paquier.xyz> <20230615041044.GA736001@nathanxps13>
	 <20230615235700.GA877311@nathanxps13>
	 <20230616052025.GA1026700@nathanxps13>
	 <20230619215534.GA442477@nathanxps13>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/dd53c632abf86fc6dacf6653f9fbab9110ccdc14.camel%40j-davis.com>
Precedence: bulk

On Mon, 2023-06-19 at 14:55 -0700, Nathan Bossart wrote:
> In v4 of the patch set, I moved the skip_privs flag refactoring to
> 0001.=C2=A0 I
> intend to commit this tomorrow unless there is additional feedback.

I think v4-0001 broke the handling of toast tables? It looks like you
removed the check for !skip_privs but need to add it to the flags in
vacuum_is_permitted_for_relation().=20

Regards,
	Jeff Davis