public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andrew Dunstan <[email protected]>
To: Juan José Santamaría Flecha <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree
Date: Tue, 18 Jan 2022 16:17:26 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAC+AXB0Mif-bfRz9TTX1W5tSjGcOHKAoPrMTk3aLfeZe6NYThA@mail.gmail.com>
References: <CAC+AXB0_fxYGbQoaYjCA8um7TTbOVP4L9aXnVmHwK8WzaT4gdA@mail.gmail.com>
	<[email protected]>
	<CAC+AXB0Mif-bfRz9TTX1W5tSjGcOHKAoPrMTk3aLfeZe6NYThA@mail.gmail.com>


On 1/18/22 15:08, Juan José Santamaría Flecha wrote:
>
>
>
>     > By the way, are pgbison.bat and pgflex.bat directly called anywhere?
>
>     Not to my knowledge. One of the things that's annoying about them is
>     that the processor names are hardcoded, so if you install winflexbison
>     as I usually do you have to rename the executables (or rename the
>     chocolatey shims) or the scripts won't work.
>
> We could use those batches to get to the hardcoded name, but that
> would probably be as annoying as renaming. If those batches serve no
> purpose right now, it should be fine to remove them from the tree. I
> use the executables from a MinGW installation, and they keep their
> actual name.
>

OK, but I don't think we should require installation of MinGW for an
MSVC build.


cheers


andrew

--

Andrew Dunstan

EDB: https://www.enterprisedb.com







view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox