public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Subject: Re: Make prep_status() message translatable
Date: Mon, 7 Apr 2025 16:26:39 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>



On 2025/04/07 15:55, Kyotaro Horiguchi wrote:
> Hello,
> 
> The recent commit 173c97812ff made the following change:
> 
> -	prep_status("Adding \".old\" suffix to old global/pg_control");
> +	prep_status("Adding \".old\" suffix to old " XLOG_CONTROL_FILE);
> 
> This change results in a message that is untranslatable, at least into
> Japanese.  In addition, the file name should be quoted.
> 
> The attached patch modifies the message to use %s for XLOG_CONTROL_FILE,
> making it properly translatable.

Thanks for the report and patch!

The fix looks good to me.

		pg_log(PG_REPORT, "\n"
			   "If you want to start the old cluster, you will need to remove\n"
			   "the \".old\" suffix from %s/%s.old.\n"
			   "Because \"link\" mode was used, the old cluster cannot be safely\n"
			   "started once the new cluster has been started.",
			   old_cluster.pgdata, XLOG_CONTROL_FILE);

Commit 173c97812ff also updated the above part of disable_old_cluster()
and replaced the hardcoded "global/pg_control" with %s using XLOG_CONTROL_FILE.
Maybe we should also add a translator: comment and wrap %s/%s.old in
double quotes there?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Make prep_status() message translatable
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox