Content-Type: multipart/alternative;
	boundary="------------vhwOsBJbyCTmwPangVerC4Px"
Message-ID: <ddee3c71-4e53-94c8-d823-3cee11c63c07@amazon.com>
Date: Mon, 5 Sep 2022 11:56:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.0.2
Subject: Re: more descriptive message for process termination due to
 max_slot_wal_keep_size
Content-Language: en-US
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, <sawada.mshk@gmail.com>
CC: <ashutosh.bapat.oss@gmail.com>, <pgsql-hackers@postgresql.org>
References: <20211224.173016.2237752923975758130.horikyota.ntt@gmail.com>
 <CAD21AoD7cGS_NtxpNiqKQdtS0xm7OZSt1GamGqhKy8SC2OjFvw@mail.gmail.com>
 <20220104.102931.1400105396066285349.horikyota.ntt@gmail.com>
 <20220302.153719.171492355527427161.horikyota.ntt@gmail.com>
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
In-Reply-To: <20220302.153719.171492355527427161.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ddee3c71-4e53-94c8-d823-3cee11c63c07%40amazon.com>
Precedence: bulk

--------------vhwOsBJbyCTmwPangVerC4Px
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 3/2/22 7:37 AM, Kyotaro Horiguchi wrote:
> At Tue, 04 Jan 2022 10:29:31 +0900 (JST), Kyotaro Horiguchi<horikyota.ntt@gmail.com>  wrote in
>> So what do you say if I propose the following?
>>
>> LOG:  terminating process %d to release replication slot \"%s\"
>> because its restart_lsn %X/%X exceeds the limit %X/%X
>> HINT: You might need to increase max_slot_wal_keep_size.
> This version emits the following message.
>
> [35785:checkpointer] LOG:  terminating process 36368 to release replication slot "s1" because its restart_lsn 0/1F000148 exceeds the limit 0/21000000
> [35785:checkpointer] HINT:  You might need to increase max_slot_wal_keep_size.

As the hint is to increase max_slot_wal_keep_size, what about reporting 
the difference in size (rather than the limit lsn)? Something along 
those lines?

[35785:checkpointer] LOG:  terminating process 36368 to release replication slot "s1" because its restart_lsn 0/1F000148 exceeds the limit by <NNN MB>.

Regards,

-- 

Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services:https://aws.amazon.com

--------------vhwOsBJbyCTmwPangVerC4Px
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body text="#415ce2" bgcolor="#FFFFFF">
    <p>Hi,<br>
    </p>
    <div class="moz-cite-prefix">On 3/2/22 7:37 AM, Kyotaro Horiguchi
      wrote:
    </div>
    <blockquote type="cite"
      cite="mid:20220302.153719.171492355527427161.horikyota.ntt@gmail.com">
      <pre class="moz-quote-pre" wrap="">At Tue, 04 Jan 2022 10:29:31 +0900 (JST), Kyotaro Horiguchi <a class="moz-txt-link-rfc2396E" href="mailto:horikyota.ntt@gmail.com">&lt;horikyota.ntt@gmail.com&gt;</a> wrote in
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">So what do you say if I propose the following?

LOG:  terminating process %d to release replication slot \"%s\"
because its restart_lsn %X/%X exceeds the limit %X/%X
HINT: You might need to increase max_slot_wal_keep_size.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
This version emits the following message.

[35785:checkpointer] LOG:  terminating process 36368 to release replication slot "s1" because its restart_lsn 0/1F000148 exceeds the limit 0/21000000
[35785:checkpointer] HINT:  You might need to increase max_slot_wal_keep_size.</pre>
    </blockquote>
    <p>As the hint is to increase max_slot_wal_keep_size, what about
      reporting the difference in size (rather than the limit lsn)?
      Something along those lines?<br>
    </p>
    <pre class="moz-quote-pre" wrap="">[35785:checkpointer] LOG:  terminating process 36368 to release replication slot "s1" because its restart_lsn 0/1F000148 exceeds the limit by &lt;NNN MB&gt;.</pre>
    <p></p>
    Regards,<br>
    <p>-- </p>
    <pre class="moz-signature" cols="72">Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: <a class="moz-txt-link-freetext" href="https://aws.amazon.com">https://aws.amazon.com</a></pre>
  </body>
</html>

--------------vhwOsBJbyCTmwPangVerC4Px--