public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Tom Lane <[email protected]>
To: Andres Freund <[email protected]>
Cc: Jelte Fennema <[email protected]>
Cc: Peter Geoghegan <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: Jesse Zhang <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Fri, 3 Feb 2023 11:44:46 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CABUevEwGPPaUtObrDywO+vhpFDTJXO+-aeWJd7D46uXTE2sQpA@mail.gmail.com>
<CAGECzQQs+hz4uQSmD_8oRLr74GtxpE0iXuYE85+RHAzvkF_yvQ@mail.gmail.com>
<[email protected]>
<CAH2-Wzn_L_kLCw_OLhpBztKwn_aaM0QLmMmubGK4KSxQyJPkbA@mail.gmail.com>
<[email protected]>
<CAH2-WzkHHcPRMj3G1b_dUfY0aR4W4OAHQ9_Z6sDGvL8Ew+aRrA@mail.gmail.com>
<[email protected]>
<CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com>
<[email protected]>
<CAGECzQRYjHdNQ-Bq2yrBb-8s3Pjx7pfvYPDdNv9tcvDcscDhbg@mail.gmail.com>
<[email protected]>
<[email protected]>
On 2023-01-22 Su 17:47, Tom Lane wrote:
> Andres Freund<[email protected]> writes:
>> I strongly dislike it, I rarely get it right by hand - but it does have some
>> benefit over aligning variable names based on the length of the type names as
>> uncrustify/clang-format: In their approach an added local variable can cause
>> all the other variables to be re-indented (and their initial value possibly
>> wrapped). The fixed alignment doesn't have that issue.
> Yeah. That's one of my biggest gripes about pgperltidy: if you insert
> another assignment in a series of assignments, it is very likely to
> reformat all the adjacent assignments because it thinks it's cool to
> make all the equal signs line up. That's just awful. You can either
> run pgperltidy on new code before committing, and accept that the feature
> patch will touch a lot of lines it's not making real changes to (thereby
> dirtying the "git blame" history) or not do so and thereby commit code
> that's not passing tidiness checks. Let's *not* adopt any style that
> causes similar things to start happening in our C code.
Modern versions of perltidy give you much more control over this, so
maybe we need to investigate the possibility of updating. See the latest
docco at
<*https://metacpan.org/dist/Perl-Tidy/view/bin/perltidy#Completely-turning-off-vertical-alignment-with...;
*
Probably we'd want to use something like
|--valign-exclusion-list=||'= => ,'|
||
||
|cheers|
||
|andrew|
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox