Feedback-ID: i131946ab:Fastmail
Message-ID: <de21d0dc-cc09-430d-f74e-1121028632cf@enterprisedb.com>
Date: Tue, 31 Jan 2023 16:28:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: Underscores in numeric literals
Content-Language: en-US
To: Dean Rasheed <dean.a.rasheed@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
References: <84aae844-dc55-a4be-86d9-4f0fa405cc97@enterprisedb.com>
 <4015800.1672152932@sss.pgh.pa.us>
 <dd65d444-4aad-6c49-6df7-91200097a6c7@dunslane.net>
 <CAEZATCUJPJHMokBEm4cYmq0t8T5hXMiKz6Rkqj5+EWOWF-==3A@mail.gmail.com>
 <CAEZATCVw8pqVn48S5ek6ZtAqWzjrJ+2q0-w3J=pOBKULwSPb-g@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAEZATCVw8pqVn48S5ek6ZtAqWzjrJ+2q0-w3J=pOBKULwSPb-g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/de21d0dc-cc09-430d-f74e-1121028632cf%40enterprisedb.com>
Precedence: bulk

On 23.01.23 21:45, Dean Rasheed wrote:
> On Wed, 4 Jan 2023 at 09:28, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>>
>> In addition, I think that strip_underscores() could then go away if
>> numeric_in() were made to handle underscores.
>>
>> Essentially then, that would move all responsibility for parsing
>> underscores and non-decimal integers to the datatype input functions,
>> or their support routines, rather than having it distributed.
> 
> Here's an update with those changes.

This looks good to me.

Did you have any thoughts about what to do with the float types?  I 
guess we could handle those in a separate patch?