public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: vignesh C <[email protected]>
Cc: Dean Rasheed <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: jian he <[email protected]>
Subject: Re: Virtual generated columns
Date: Fri, 7 Feb 2025 13:36:28 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALDaNm3Y5Dx2fPcPprhoof4CbxG9+XKM4q7LuERNaAtNThhmcQ@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CAEZATCUHnmOu7RtDuP+PCtS_dqvU8hFsAYYFPdiB8gyFszj5WQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CAEZATCXQcjZPq+OsczFc13M6v+OP_NiqmUAcRAzi1K60KFuWmQ@mail.gmail.com>
<[email protected]>
<CAEZATCXnp5XTkUCsmfjLXVWZ7TaibWatnXDdu52J6zN3XsyZhw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAEZATCX6SHevKrVfAOq+88b4Ysm4Rqq2yeO6He3N0pttEbjYag@mail.gmail.com>
<[email protected]>
<CALDaNm3Y5Dx2fPcPprhoof4CbxG9+XKM4q7LuERNaAtNThhmcQ@mail.gmail.com>
On 06.02.25 14:03, vignesh C wrote:
> One suggestion: for the option where the user specifies
> publish_generated_columns as virtual (as shown below), could we change
> the error indicating that virtual generated columns are not currently
> supported?
> CREATE PUBLICATION pub1 FOR TABLE t1 WITH (publish_generated_columns = virtual);
>
> Also, could we add a XXX comment in either decode.c, pgoutput.c, or
> publicationcmds.c outlining what would be needed to support the
> replication of virtual generated columns? Specifically, it would be
> helpful if we could include how to retrieve virtual generated column
> data during decoding. This would serve as a reference for anyone
> working on enabling logical replication of virtual generated columns
> in the future.
I think adding support for virtual generated columns in logical
replication would require a lot more work than filling in the handful of
places that we know about. (Otherwise, we'd already have done it now.)
So I'd rather not give potentially misleading or incomplete advice.
view thread (75+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Virtual generated columns
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox