Message-ID: <de595a8e-2fc0-4931-94e5-3cb00d91d698@proxel.se>
Date: Mon, 23 Feb 2026 03:28:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: refactor ExecInitPartitionInfo
To: jian he <jian.universality@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <CACJufxEN_mmgTtp-raJ9-VJHgyAGmb0SrO+01kn5by4mJ_XOfw@mail.gmail.com>
 <CACJufxGcUztOYcCj85o15YT68qPY3qpwUtdndqDgOs_Sps6Cow@mail.gmail.com>
From: Andreas Karlsson <andreas@proxel.se>
Content-Language: en-US
In-Reply-To: <CACJufxGcUztOYcCj85o15YT68qPY3qpwUtdndqDgOs_Sps6Cow@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/de595a8e-2fc0-4931-94e5-3cb00d91d698%40proxel.se>
Precedence: bulk

On 2/21/26 4:07 PM, jian he wrote:
> V1 is way too complicated.
> IMHO, we can just do
> 
>      if (node != NULL)
>          part_attmap = build_attrmap_by_name(RelationGetDescr(partrel),
>                                              RelationGetDescr(firstResultRel),
>                                              false);
> 
> We have now consolidated five uses of build_attrmap_by_name into one.

Hm, why would that be ok? As far as I can tell the current code tries 
hard to not build the attmap unless it is actually needed while you 
propose to build it almost unconditionally. While the code is less 
complicated with your patch it instead has to do more work in some 
cases, right?

Andreas