Subject: Re: adding partitioned tables to publications
To: Amit Langote <amitlangote09@gmail.com>
References: 
 <CA+HiwqH=Y85vRK3mOdjEkqFK+E=ST=eQiHdpj43L=_eJMOOznQ@mail.gmail.com>
 <CA+HiwqHScTtXD97yC_ZRLk7TXf+0HYH+UeDvACf2Q-LBH-2ctw@mail.gmail.com>
 <CA+FpmFfKmsNww_C5hWU-=wg9h3cyV7vZcCUKWrrhtLkteUtY4w@mail.gmail.com>
 <CA+HiwqE2ie6_T01fMzsf7c5=hCGoVdj2yTStCJ78zOmayMVWbw@mail.gmail.com>
 <825b31ea-ad9f-21d1-29b6-2a494513458d@2ndquadrant.com>
 <CA+HiwqEqm3xvnMHjstkrECrpVv9R7YgYYpRHHVrffSvA9Zrf9g@mail.gmail.com>
 <CA+HiwqGiFpkHxx0mc2zpdJLGzfqEaqsdqUZurNto9kbkwzcQ1w@mail.gmail.com>
 <CA+FpmFfve1TtLvj5CwpgEZrjNiFG-EWh4ywpbtrB7-UTkZo2gg@mail.gmail.com>
 <CA+HiwqHfV73E4aJxX6d79xSEZjp+stFKnD0+7OktPw2_tD=pYg@mail.gmail.com>
 <73a1877a-6f1d-9f2e-da51-bc2eb57e07d5@2ndquadrant.com>
 <CA+HiwqFjo=vCXDdkwprf6ipaVeegCpW79n-Ds8BK5cNQsSey2A@mail.gmail.com>
 <d760bb60-563c-dd01-9903-f9337d50e8a6@2ndquadrant.com>
 <CA+HiwqFBni-cXy5NBN0PdwxidXgcCEio0N_AOnOM0pR2dMWUyA@mail.gmail.com>
 <9dfea57a-41a6-06d4-ad18-463aeec7ea91@2ndquadrant.com>
 <CA+HiwqF-eZ91mph5L9rtRbm8kXUCHSa01-Zo5RAqWm2FpPF7Kg@mail.gmail.com>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <de683090-6dcd-7f8e-3bcc-955c427c60ca@2ndquadrant.com>
Date: Thu, 19 Mar 2020 09:05:32 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: 
 <CA+HiwqF-eZ91mph5L9rtRbm8kXUCHSa01-Zo5RAqWm2FpPF7Kg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-03-18 15:19, Amit Langote wrote:
> On Wed, Mar 18, 2020 at 8:16 PM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> On 2020-03-18 04:06, Amit Langote wrote:
>>> +   if (isnull || !remote_is_publishable)
>>> +       ereport(ERROR,
>>> +               (errmsg("table \"%s.%s\" on the publisher is not publishable",
>>> +                       nspname, relname)));
>>>
>>> Maybe add a one-line comment above this to say it's an "not supposed
>>> to happen" error or am I missing something?  Wouldn't elog() suffice
>>> for this?
>>
>> On second thought, maybe we should just drop this check.  The list of
>> tables that is part of the publication was already filtered by the
>> publisher, so this query doesn't need to check it again.  We just need
>> the relkind to be able to construct the COPY command, but we don't need
>> to second-guess it beyond that.
> 
> Agreed.

Committed with that change then.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services