Feedback-ID: ie0a040ee:Fastmail
Message-ID: <deb94c8a-673e-4a25-97ca-c0b2cc22effc@eisentraut.org>
Date: Mon, 26 Jan 2026 16:09:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Fix accidentally cast away qualifiers
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <b04f4d3a-5e70-4e73-9ef2-87f777ca4aac@eisentraut.org>
 <aW9w0cD60CVVqheF@ip-10-97-1-34.eu-west-3.compute.internal>
 <e9088f15-d3f1-464e-a6e6-7c7fd94b909b@eisentraut.org>
 <aXDhus3a7j+dTyUe@ip-10-97-1-34.eu-west-3.compute.internal>
 <aXDpJUt5QenOlPSl@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <aXDpJUt5QenOlPSl@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/deb94c8a-673e-4a25-97ca-c0b2cc22effc%40eisentraut.org>
Precedence: bulk

On 21.01.26 15:56, Bertrand Drouvot wrote:
> Hi,
> 
> On Wed, Jan 21, 2026 at 02:24:58PM +0000, Bertrand Drouvot wrote:
>> Hi,
>>
>> On Wed, Jan 21, 2026 at 12:31:27PM +0100, Peter Eisentraut wrote:
>>> Strange, I don't see that.  What compiler is this, and do you use any
>>> special options?
>>
>> It's gcc 14.1.0 with "CFLAGS=-O0 -ggdb3 -fno-omit-frame-pointer -gdwarf-2 -g3
>> -Wdiscarded-qualifiers -Wunused-value -Werror=maybe-uninitialized
>> -Werror=format -Wreturn-type"
>>
>> But I just tested with a simple test case, some compilers and some options and I've
>> always seen the warning (see [1])
> 
> FWIW, and so does the CI: https://github.com/bdrouvot/postgres/runs/61028037498

I must have done something wrong on my side.  I have committed it with 
your corrections.