Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuZ5x-009q19-3K for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 15:43:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tuZ5v-00HHIy-36 for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Mar 2025 15:43:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tuZ5u-00HHIq-Ds for pgsql-hackers@lists.postgresql.org; Tue, 18 Mar 2025 15:43:06 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tuZ5r-003XFk-2L for pgsql-hackers@postgresql.org; Tue, 18 Mar 2025 15:43:04 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2ff4a4f901fso5783125a91.2 for ; Tue, 18 Mar 2025 08:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1742312583; x=1742917383; darn=postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=1UlNZ9zWAVLxeBKWVQjc8hC2Sz/8WNvWP3ZqujzcYBM=; b=vaWAK6H+vt/cbrQW4tF38rUpoopGp7mNqRvPCDqoC2KAZUWal78lhpKSMEaQkoxrx7 DuzDRe253HGnABScZzlgZD7h37R1MalXcjpq9GUm1uDn9TIxL8fkHC1WHDgrF/cyQ0+w VZF0G5ij9NrhFRiFiNMty73XgnZ/xL1FJdxegSC3lSvtIDZeGTkktefkBOl5i6EhDCND A1JY1Zy6aJMv6KyfS9o73Ib8ax0zGkDXkeovjY1kvsEu3NIAapc0Tt6Co+iqvmbiATx0 RJggNykcCDNKp7KgLLJQp8bALBelzEfwY0QkjLmJgTplcBjoy2I87wWDnHsqyA3rl+3Q jJdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742312583; x=1742917383; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1UlNZ9zWAVLxeBKWVQjc8hC2Sz/8WNvWP3ZqujzcYBM=; b=t41QdiiBqfScvJX6PJdYPdcZIWgu2S+7mvu+YGLpV2Qg+pdzrZU6+iP7GlSNp5WESQ oITo3K9nUm5g7QGgjzBPn3/ZrzMrgff+uelSMNuxLznnpfCx4OFGNAHW6ReApcQA+xoo Ln2uoee4f83EGkF7G17MvRyW1NqCcmWZ9JBPrdneOCJVq/tYiWc1G7a9AvVJ3k9grn/D SKArTgkiYJA3kdiFPRCHDmjz9CrgExVFxUKxM5jsJi3dQ/H2DJ8kqQuq00naXkTTyC8n YuxvvJvjogxWw/8QIbYPzCajvQ/wjoQ7b/PfHUpz1IypAekpC/R0RxquX173RsqiSNKs +D+w== X-Forwarded-Encrypted: i=1; AJvYcCXnvhClg6symP7puBCKHImFyMddUANCRwQsCKZhwlS6hxBku1DJLM+enRtvOvwOnF7p/wVoAO1g7LV/NsIu@postgresql.org X-Gm-Message-State: AOJu0Yxt3adLkTliVoEv5xtLsKIZYxGznacuvfzTy1zrwGLKlXEpp0DG Xai72bUjxRBBtrh0/oZW5H7CREPm+Ux21Zu7dRICY3IIXLgVQiu1EJfInZHgzQEtDUc2pjtK+Sj Scg== X-Gm-Gg: ASbGncvlcyiJYH6HBo4F6j4/n5GtJ93jk0pdQkZ0i9LJCbANWtiKtndTqRPfTh7B+K+ vU2vPnkudfXksx4mBleH+T0NWRzdFpmnacAlmBmg9BSTdWuGzdscxT+Pbri3+A2ZugR9qZfvp1V cnT4XBL04R4FHK5p/2rEjTR51n2bzXFAx8kKauV6aEBb1sWu9M7J6rSrUH9MTperH11/UOFyjCl lHX3666sMzbnmfvx0TH3+IREXe5Fodylq9rfIvQfI0CT7KlvUjGxCsnXzUUo+D59LOtLw64m2aN 8FUaKP8BwR0/KY6Y+Ctzx3LUe/tvmg8swl1L03rmhQhjWTF/K8P8YWwsXNkvz6iau7Qc47/9MCJ 7B1hbcjQe/nhu/CtdnSgsLw== X-Google-Smtp-Source: AGHT+IEkTMUOVyNn0BAeegfjs3rmdY8oiqPRiMhN7mig28sGeiya8sC9p2eYw6SxD09OVIjZ4qYQpQ== X-Received: by 2002:a17:90b:3e82:b0:2ff:7b28:a519 with SMTP id 98e67ed59e1d1-301a5b9878cmr3169931a91.30.1742312582944; Tue, 18 Mar 2025 08:43:02 -0700 (PDT) Received: from jeff-laptop.lan (c-76-102-242-158.hsd1.ca.comcast.net. [76.102.242.158]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30153b9e957sm8340538a91.36.2025.03.18.08.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 08:43:02 -0700 (PDT) Message-ID: Subject: Re: Optimization for lower(), upper(), casefold() functions. From: Jeff Davis To: Tom Lane Cc: Alexander Borisov , Heikki Linnakangas , pgsql-hackers@postgresql.org Date: Tue, 18 Mar 2025 08:42:59 -0700 In-Reply-To: <93731.1742310701@sss.pgh.pa.us> References: <7cac7e66-9a3b-4e3f-a997-42aa0c401f80@gmail.com> <7ab9d255-d7c0-4841-96c3-ed3ce9aa4abd@iki.fi> <12956299-1496-4455-b3ab-299cc0a87d7c@gmail.com> <340f2451-cd76-487b-a1e4-0f0a2fe91fba@gmail.com> <3ffb8b75b26e76624668c0883cac7886468c5d07.camel@j-davis.com> <5cf176fa-44b9-4019-b9b7-ee902352a844@gmail.com> <3080de9bcce916cf8720ac197f634e381c4de564.camel@j-davis.com> <1e3f4f6f-9b12-4109-b0d2-a4c52b5064f8@gmail.com> <4f3772355e038acd3cfe0be43ae2c1aacae1794d.camel@j-davis.com> <2c10910c21b16cb9a0e5f67d80589e3acae2b6ef.camel@j-davis.com> <44005c3d-88f4-4a26-981f-fd82dfa8e313@gmail.com> <2a9e520ba41b318df8ed396ef99ed1e3d3e4b5b6.camel@j-davis.com> <177451ea791a1! f90039ea3047f1f890b1f9ae1db.camel@j-davis.com> <3505356.1742069486@sss.pgh.pa.us> <93731.1742310701@sss.pgh.pa.us> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, 2025-03-18 at 11:11 -0400, Tom Lane wrote: > It's not apparent to me why that table needs to be in a header > file and not in the sole user .c file? Thank you, fixed. > Also, probably better to make it const: >=20 > -static const pg_wchar *casekind_map[NCaseKind] =3D > +static const pg_wchar * const casekind_map[NCaseKind] =3D Fixed also (except pgindent had a slightly different opinion about spaces). Was this a general suggestion, or did you see something in particular that would make it more optimizable this way? Regards, Jeff Davis