Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4HSM-000760-FU for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Jun 2022 07:40:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o4HSL-0005RI-3i for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Jun 2022 07:40:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4HSK-0005Qj-3D for pgsql-hackers@lists.postgresql.org; Thu, 23 Jun 2022 07:40:48 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o4HSH-00084t-PT for pgsql-hackers@lists.postgresql.org; Thu, 23 Jun 2022 07:40:47 +0000 Received: by mail-ed1-x52c.google.com with SMTP id eq6so19919681edb.6 for ; Thu, 23 Jun 2022 00:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to; bh=9rZWipfYR5Ej0sPxzNsS7MXDii8FKrvE5Uz2niBIDvc=; b=lCR/0JusvVyGnDxo9o2pmyVJW2a94O7udahYYPU4zYh1beMg03mGLo7GmvNl05XzFj /bDSctJihJJ3n0pmF05DTTlgoT9nlm95VW6zxyVIRFrKgCERYwcaDK6CCPrkRyDC8D9b M9//Ki93Z53RAbBSswpDxS2bfDKbr2qsAAR4V5FyrJxdkup1n6ep2qrdWJrkm+MKdcmS FlEvRM1Q2aqOxMd/OPoCmr8iJnULc6vUFaAnHaX5gBA7MhdnE8K41YB+2GNOcOufGv+Y vAegmy+7BcRXcvQZdprvS/PG+Dx++OV2gbqwXNnc3Gn5407ItjdcMvBmyTOMCm3zEY0J 1wqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to; bh=9rZWipfYR5Ej0sPxzNsS7MXDii8FKrvE5Uz2niBIDvc=; b=vTdpVUAC0xcVXPYigI/iiDGCPZILrSnMyNSIhYIbrHXydkvYxJzPS7nF1mmzYbhalb iI4mrJeKDEeoBDig+AKRUoTdpUvVfWgJwX0WnnhGhyKfc/unn8ZdRvTmLwJVGN5W+N/Z a4gpUeABcT5sk5tS9fQU6To1ZM0UxXIlO2cySVwiSkIGUjPCPl15cYy++0HYM7vbiAtX Tb/REnJr4Uqf5Ga4bDgkJbSv47bHWHF6vu7vZAkhgajnMBY3SBpZgl6tgaG9TIw/9m2R T+1/EtBuSI2EY2GT0ap4MnZQQEErdt9sareLwQV83oS68l96t4/+il3iHqDgmJYGPOTD 7mLg== X-Gm-Message-State: AJIora/h41b7h0uu6t+PYC8SLt8/0akHJpr0VUXThHfeen778MZLhbZB m/yynUH3uXT5tjld/bcmjivzGI4x0DKjhkaaNHvoUjSVaM+oj6aMIqRKzigMKkVGctalPDK8R6t rAYeLwJQ+3I92IIR+C+ECXyY6BoItih+Lz3cXsbtiwzgR1UneOvu0tF+GgaJEVSbNaewmh/nINL qEHsL/KPRIPa1A8FfYhwjrjbXw4KlBBKer/mz+rb6vRDYX5o3N6rQ0 X-Google-Smtp-Source: AGRyM1sCt32tDHziKGIEWkSl2F1IVySWPcebKpLwu16wQFvonmX5xVWrRmnPkRu1vLnKjluWoCWm6w== X-Received: by 2002:a05:6402:f29:b0:435:c108:58f2 with SMTP id i41-20020a0564020f2900b00435c10858f2mr4600053eda.401.1655970044380; Thu, 23 Jun 2022 00:40:44 -0700 (PDT) Received: from [10.80.10.5] ([145.40.212.39]) by smtp.gmail.com with ESMTPSA id jw12-20020a170906e94c00b0072354a54137sm785925ejb.34.2022.06.23.00.40.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jun 2022 00:40:43 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------y6DM7QLv4ja2b5tFUSR9yCbN" Message-ID: Date: Thu, 23 Jun 2022 09:41:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: fix crash with Python 3.11 Content-Language: en-US To: Tom Lane , Peter Eisentraut Cc: exclusion@gmail.com, pgsql-hackers@lists.postgresql.org References: <3375ffd8-d71c-2565-e348-a597d6e739e3@enterprisedb.com> <3890110.1642373624@sss.pgh.pa.us> <73daabb7-9fc7-fb7a-5e06-a968c611b032@enterprisedb.com> <2255118.1643126084@sss.pgh.pa.us> <1103370.1644273481@sss.pgh.pa.us> <1216692.1645644682@sss.pgh.pa.us> <1533956.1645731245@sss.pgh.pa.us> <3027328.1655829211@sss.pgh.pa.us> From: Markus Wanner In-Reply-To: <3027328.1655829211@sss.pgh.pa.us> X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------y6DM7QLv4ja2b5tFUSR9yCbN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/21/22 18:33, Tom Lane wrote: > My inclination at this point is to not back-patch the second change > 12d768e70 ("Don't use static storage for SaveTransactionCharacteristics"). > It's not clear that the benefit would be worth even a small risk of > somebody being unhappy about the API break. Actually, the backport of 2e517818f ("Fix SPI's handling of errors") already broke the API for code using SPICleanup, as that function had been removed. Granted, it's not documented, but still exported. I propose to re-introduce a no-op placeholder similar to what we have for SPI_start_transaction, somewhat like the attached patch. Regards Markus --------------y6DM7QLv4ja2b5tFUSR9yCbN Content-Type: text/x-patch; charset=UTF-8; name="add-spicleanup-placeholder.diff" Content-Disposition: attachment; filename="add-spicleanup-placeholder.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL3NwaS5jIGIvc3JjL2JhY2tlbmQv ZXhlY3V0b3Ivc3BpLmMKaW5kZXggZGQ1ZWY3NjI3MDcuLmY3M2MxZTc5ZTE4IDEwMDY0NAot LS0gYS9zcmMvYmFja2VuZC9leGVjdXRvci9zcGkuYworKysgYi9zcmMvYmFja2VuZC9leGVj dXRvci9zcGkuYwpAQCAtNDIyLDYgKzQyMiwxNiBAQCBTUElfcm9sbGJhY2tfYW5kX2NoYWlu KHZvaWQpCiAJX1NQSV9yb2xsYmFjayh0cnVlKTsKIH0KIAorLyoKKyAqIFNQSUNsZWFudXAg aXMgYSBuby1vcCwga2VwdCBmb3IgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkuIFdlIHJlbHkg b24KKyAqIEF0RU9YYWN0X1NQSSB0byBjbGVhbnVwLiBFeHRlbnNpb25zIHNob3VsZCBub3Qg KG5lZWQgdG8pIGZpZGRsZSB3aXRoIHRoZQorICogaW50ZXJuYWwgU1BJIHN0YXRlIGRpcmVj dGx5LgorICovCit2b2lkCitTUElDbGVhbnVwKHZvaWQpCit7Cit9CisKIC8qCiAgKiBDbGVh biB1cCBTUEkgc3RhdGUgYXQgdHJhbnNhY3Rpb24gY29tbWl0IG9yIGFib3J0LgogICovCmRp ZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9leGVjdXRvci9zcGkuaCBiL3NyYy9pbmNsdWRlL2V4 ZWN1dG9yL3NwaS5oCmluZGV4IDE1M2ViNWM3YWQ1Li4xZTY2YTdkMmVhMCAxMDA2NDQKLS0t IGEvc3JjL2luY2x1ZGUvZXhlY3V0b3Ivc3BpLmgKKysrIGIvc3JjL2luY2x1ZGUvZXhlY3V0 b3Ivc3BpLmgKQEAgLTIwNSw2ICsyMDUsNyBAQCBleHRlcm4gdm9pZCBTUElfY29tbWl0X2Fu ZF9jaGFpbih2b2lkKTsKIGV4dGVybiB2b2lkIFNQSV9yb2xsYmFjayh2b2lkKTsKIGV4dGVy biB2b2lkIFNQSV9yb2xsYmFja19hbmRfY2hhaW4odm9pZCk7CiAKK2V4dGVybiB2b2lkIFNQ SUNsZWFudXAodm9pZCk7CiBleHRlcm4gdm9pZCBBdEVPWGFjdF9TUEkoYm9vbCBpc0NvbW1p dCk7CiBleHRlcm4gdm9pZCBBdEVPU3ViWGFjdF9TUEkoYm9vbCBpc0NvbW1pdCwgU3ViVHJh bnNhY3Rpb25JZCBteVN1YmlkKTsKIGV4dGVybiBib29sIFNQSV9pbnNpZGVfbm9uYXRvbWlj X2NvbnRleHQodm9pZCk7Cg== --------------y6DM7QLv4ja2b5tFUSR9yCbN--