Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1msqDb-0000cn-Bz
	for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Dec 2021 17:50:03 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1msqDa-0002FS-07
	for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Dec 2021 17:50:02 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <david@pgmasters.net>)
	id 1msqDZ-0002FB-Mc
	for pgsql-hackers@lists.postgresql.org; Thu, 02 Dec 2021 17:50:01 +0000
Received: from mail.thelabyrinth.net ([45.56.70.56])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <david@pgmasters.net>)
	id 1msqDT-0006oT-4J
	for pgsql-hackers@postgresql.org; Thu, 02 Dec 2021 17:50:00 +0000
Received: from [IPV6:2607:fb90:5582:b544:d1f3:e4e9:ac32:676] (unknown
 [172.58.231.131])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: dsteele)
	by mail.thelabyrinth.net (Postfix) with ESMTPSA id 7350F5469C;
	Thu,  2 Dec 2021 17:49:53 +0000 (UTC)
Message-ID: <df3f0f28-4023-0c1a-dbc4-a92804e78054@pgmasters.net>
Date: Thu, 2 Dec 2021 12:49:52 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: Postgres restart in the middle of exclusive backup and the
 presence of backup_label file
Content-Language: en-US
From: David Steele <david@pgmasters.net>
To: Andrew Dunstan <andrew@dunslane.net>,
 "Bossart, Nathan" <bossartn@amazon.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>,
 Laurenz Albe <laurenz.albe@cybertec.at>,
 Michael Paquier <michael@paquier.xyz>,
 Pg Hackers <pgsql-hackers@postgresql.org>,
 SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
References: 
 <CAHg+QDfiM+WU61tF6=nPZocMZvHDzCK47Kneyb0ZRULYzV5sKQ@mail.gmail.com>
 <YZ7Amotspa4ve+91@paquier.xyz>
 <CAHg+QDekOasWArvmPeOqhyTUHR40DsDOWyt7OaKxpQ7eFYqysw@mail.gmail.com>
 <YaB3Oj4GfPOZ/3LC@paquier.xyz> <417711.1637940660@sss.pgh.pa.us>
 <20211130142042.GR26257@tamriel.snowman.net>
 <3404870c1a921bafbcd168c098088981fe082ab1.camel@cybertec.at>
 <CAOuzzgoYqzH+c_fzapjGFh6kiZjXDc0jPCQctbQjajn7a4vyxA@mail.gmail.com>
 <845544A4-0B0E-41D2-903C-C8B9E8A18812@amazon.com>
 <1661037.1638311167@sss.pgh.pa.us>
 <1cce9981-2c48-981a-a936-812830dfb3b1@pgmasters.net>
 <BC31E8F0-7CFF-462E-9B27-727AD573A675@amazon.com>
 <9427c6b3-5e0b-e27f-a2e7-ec1ebc00b582@pgmasters.net>
 <AC0ADAC3-E196-42A0-9471-A22F966E1A5F@amazon.com>
 <E87F96A8-9DBD-4E8D-8EE9-A03B4F126119@amazon.com>
 <4a363c5a-473f-9cb9-9f59-74a230575340@dunslane.net>
 <553d2348-1015-3546-2be8-b5a8a745dfa8@pgmasters.net>
In-Reply-To: <553d2348-1015-3546-2be8-b5a8a745dfa8@pgmasters.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/df3f0f28-4023-0c1a-dbc4-a92804e78054%40pgmasters.net>
Precedence: bulk

On 12/2/21 12:38, David Steele wrote:
> On 12/2/21 11:00, Andrew Dunstan wrote:
>>
>> Should we really be getting rid of
>> PostgreSQL::Test::Cluster::backup_fs_hot() ?
> 
> Agreed, it would be better to update backup_fs_hot() to use exclusive 
> mode and save out backup_label instead.

Oops, of course I meant non-exclusive mode.

Regards,
-David