Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jszmA-0005aT-Pa
	for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Jul 2020 02:25:34 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jszm8-0005Lo-4E
	for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Jul 2020 02:25:32 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1jszm7-0005Lh-SC
	for pgsql-hackers@lists.postgresql.org; Wed, 08 Jul 2020 02:25:31 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1jszm5-0001KH-JZ
	for pgsql-hackers@postgresql.org; Wed, 08 Jul 2020 02:25:30 +0000
Received: from hnk.local (p2604028-ipngn12401funabasi.chiba.ocn.ne.jp
 [180.1.110.28])
	by oss.nttdata.com (Postfix) with ESMTPSA id 202506022B;
	Wed,  8 Jul 2020 11:25:27 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com
Subject: Re: [doc] modifying unit from characters to bytes
To: torikoshia <torikoshia@oss.nttdata.com>, pgsql-hackers@postgresql.org
References: <cd5b49a5a14e887542f5f569c1c6bde2@oss.nttdata.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <df4c5cef-2f69-ca3c-60e2-c784c404f02d@oss.nttdata.com>
Date: Wed, 8 Jul 2020 11:25:26 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <cd5b49a5a14e887542f5f569c1c6bde2@oss.nttdata.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk



On 2020/07/08 10:54, torikoshia wrote:
> Hi,
> 
> The manual describes the size of pg_stat_activity.query
> as below:
> 
>   | By default the query text is truncated at 1024 characters;
> 
> When considering multibyte characters, it seems more
> accurate to change the unit from "characters" to "bytes".

Agreed. Barring any objection, I will commit this patch.

For record, this change derived from the discussion about other patch [1].

Regards,

[1]
https://postgr.es/m/cd0e961fd42e5708fdea70f7420bf214@oss.nttdata.com


-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION