Feedback-ID: ie0a040ee:Fastmail
Message-ID: <df78eaac-c2eb-4344-852e-0965c75c5ad6@eisentraut.org>
Date: Tue, 20 Jan 2026 20:07:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Make copyObject work in C++
To: Andres Freund <andres@anarazel.de>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Thomas Munro <thomas.munro@gmail.com>
References: <CAGECzQR21OnnKiZO_1rLWO0-16kg1JBxnVq-wymYW0-_1cUNtg@mail.gmail.com>
 <4d8b9e53-3f37-43f0-a4aa-5bda9c7961b3@eisentraut.org>
 <DFEUMBSUG8KA.XGY0CN9PFPR2@jeltef.nl> <DFKV26A4CHG2.CB7NJ1X62BKH@jeltef.nl>
 <fd1a4790-4fbc-43b4-a385-e3b98b9ed04d@eisentraut.org>
 <DFQYWIJD4L1J.3HQFOWSWKLFOR@jeltef.nl>
 <4e82f77b-acad-4356-94f6-8255135fb36b@eisentraut.org>
 <ipdfcmip7oegnw5vhvf3swoqdzku3snuvskjycniync2a54yow@vpj6i5yg77ux>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <ipdfcmip7oegnw5vhvf3swoqdzku3snuvskjycniync2a54yow@vpj6i5yg77ux>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/df78eaac-c2eb-4344-852e-0965c75c5ad6%40eisentraut.org>
Precedence: bulk

On 20.01.26 17:38, Andres Freund wrote:
>> I have split your first patch further.  For a start, I left out the
>> PG_MODULE_MAGIC*-related changes and disabled the module under MSVC. This
>> has been committed.  I plan to let the buildfarm run with it for a day or
>> two and then add in the basic MSVC support.
> Seems like billbug doesn't like this:
> 
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl? 
> nm=billbug&dt=2026-01-20%2016%3A00%3A02
> 
> gmake[1]: Entering directory '/home/marcel/build-farm-20/buildroot/HEAD/pgsql.build/src/test/modules/test_cplusplusext'
> g++ -Wall -Wpointer-arith -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -I. -I. -I../../../../src/include -D_POSIX_C_SOURCE=200112L -D__EXTENSIONS__ -D_POSIX_PTHREAD_SEMANTICS  -I/usr/openssl/3/include -I/usr/include/libxml2     -c -o test_cplusplusext.o test_cplusplusext.cpp
> In file included from ../../../../src/include/postgres.h:48,
>                   from test_cplusplusext.cpp:18:
> ../../../../src/include/c.h:158:21: error: '_Noreturn' does not name a type; did you mean 'pg_noreturn'?
>    158 | #define pg_noreturn _Noreturn
>        |                     ^~~~~~~~~
> ../../../../src/include/c.h:918:1: note: in expansion of macro 'pg_noreturn'
>    918 | pg_noreturn extern void ExceptionalCondition(const char *conditionName,
>        | ^~~~~~~~~~~

It's getting confused by _Noreturn, which is defined thus:

#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 201112L
#define pg_noreturn _Noreturn

But apparently on these Solaris-related platforms, g++ defines 
__STDC_VERSION__ even in C++ mode.  (Confirmed in local testing.) 
Apparently, this is even allowed by the C++ standard.

So the smallest fix is probably to gate this more like this:

#if (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 201112L) && 
!defined(__cplusplus)
#define pg_noreturn _Noreturn

(Eventually, we could add support for C++ attributes, but one step at a 
time.)