Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1f1JGJ-00018g-EB
	for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Mar 2018 22:09:43 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1f1JGH-0005FZ-ME
	for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Mar 2018 22:09:41 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <peter.eisentraut@2ndquadrant.com>)
	id 1f1JGH-0005FQ-Eu
	for pgsql-hackers@lists.postgresql.org; Wed, 28 Mar 2018 22:09:41 +0000
Received: from out5-smtp.messagingengine.com ([66.111.4.29])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <peter.eisentraut@2ndquadrant.com>)
	id 1f1JGE-0000ex-Ah
	for pgsql-hackers@lists.postgresql.org; Wed, 28 Mar 2018 22:09:40 +0000
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
	by mailout.nyi.internal (Postfix) with ESMTP id 427F520CB1;
	Wed, 28 Mar 2018 18:09:36 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
  by compute7.internal (MEProxy); Wed, 28 Mar 2018 18:09:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:references
	:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4f1BEL
	tVbL8jWAOpri4uGxMuMUssW0Ph/D0WGgypr3E=; b=TbqDl6UoLsEiSTf1Qok90S
	GcQydTgVJPj5rSWwdqja/X+SS/LecxyBpd7LpWHqJFxgdqFqQp3U+5htuKUSYvTp
	BS56RGSSfD3f5Z/17TCX/YVm1ppuiFICX7XElKiSKYGa6KzplftHf/Ci87iGWbEC
	H4/yLklSGHhFZq5iUQJ0xagm4pgBEMHpuJvBhSjZs+AaY55ukcZWtOs1vCIAb6nR
	SD4JGDCNptpTUGv3FFurjyI99/6oFC7aoPSQ9QEMmGZsl19gjwty39hpGCy+0LT8
	epLgwsDorxRx9PHmRdxAw6xvC7Noh1tJOSyx3TD3WQRQtOBYTXo6XysDVWMO1c0A
	==
X-ME-Sender: <xms:oBK8WkLhIdEv7Z-LDCkqEZPllNDc9u-Qld7SMKg6rqjj6cgcXYc4Pg>
Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39])
	by mail.messagingengine.com (Postfix) with ESMTPA id DC2C210255;
	Wed, 28 Mar 2018 18:09:35 -0400 (EDT)
Subject: Re: WIP: Covering + unique indexes.
To: Thomas Munro <thomas.munro@enterprisedb.com>,
 Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
References: <56168952.4010101@postgrespro.ru>
 <7FEB0867-F4F2-4F18-8AA9-7BAA0BB32868@yandex-team.ru>
 <151654594496.23710.401435331419974842.pgcf@coridan.postgresql.org>
 <1d2b6e12-9e1c-8df5-fdd6-4d20d3791b86@postgrespro.ru>
 <CAEepm=2gh3nKi2u18i4r=TLhMyZf6guWSwmrHEcwm7dyJahnow@mail.gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>,
 pgsql-hackers@lists.postgresql.org,
 Anastasia Lubennikova <lubennikovaav@gmail.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <df7958cf-36d5-b2f1-0cd6-8a66325d4e27@2ndquadrant.com>
Date: Wed, 28 Mar 2018 18:09:35 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: 
 <CAEepm=2gh3nKi2u18i4r=TLhMyZf6guWSwmrHEcwm7dyJahnow@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 1/25/18 23:19, Thomas Munro wrote:
> +  PRIMARY KEY ( <replaceable
> class="parameter">column_name</replaceable> [, ... ] ) <replaceable
> class="parameter">index_parameters</replaceable> <optional>INCLUDE
> (<replaceable class="parameter">column_name</replaceable> [,
> ...])</optional> |
> 
> I hadn't seen that use of "<optional>" before.  Almost everywhere else
> we use explicit [ and ] characters, but I see that there are other
> examples, and it is rendered as [ and ] in the output.

I think this will probably not come out right in the generated psql
help.  Check that please.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services