Message-ID: <dfb99d7e-41bf-4b59-879e-7ca62ea651d6@postgrespro.ru>
Date: Fri, 4 Apr 2025 12:06:49 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Restrict publishing of partitioned table with a foreign table as
 partition
To: Shlok Kyal <shlok.kyal.oss@gmail.com>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>
Cc: vignesh C <vignesh21@gmail.com>, pgsql-hackers@lists.postgresql.org
References: 
 <CANhcyEU5R4qdkO8SLSswRWgBRDPEaapAQ61rCjjDBg4RNmmsrw@mail.gmail.com>
 <202503281104.t47zhqlep54q@alvherre.pgsql>
 <CANhcyEXVPUAir9G1G1gT9k-xAMzhiV7GRX_fr1rkRhURNKDbxg@mail.gmail.com>
Content-Language: en-US
From: Sergey Tatarintsev <s.tatarintsev@postgrespro.ru>
In-Reply-To: 
 <CANhcyEXVPUAir9G1G1gT9k-xAMzhiV7GRX_fr1rkRhURNKDbxg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/dfb99d7e-41bf-4b59-879e-7ca62ea651d6%40postgrespro.ru>
Precedence: bulk

01.04.2025 21:48, Shlok Kyal пишет:
> On Fri, 28 Mar 2025 at 16:35, Álvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>> On 2025-Mar-28, Shlok Kyal wrote:
>>
>>> On Mon, 24 Mar 2025 at 21:17, Álvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>>>> Also, surely we should document this restriction in the SGML docs
>>>> somewhere.
>>> I have added comment in create_publication.sgml
>> Hmm, okay, but "We cannot" is not the style used in the documentation.
>> In addition, I think this mechanism should be mentioned in
>> logical-replication.sgml; currently there's a note in the Restrictions
>> section about foreign tables, which should be expanded to explain this.
>>
> I have modified the comment in create_publication.sgml and also added
> comment in the restrictions section of logical-replication.sgml.
> I have also added a more detailed explanation in comment of
> 'check_foreign_tables'
>
> I have attached the updated v11 patch.
>
>
> Thanks and Regards,
> Shlok Kyal

Hi!

I looked at the latest version of the patch, and think that we should 
free puboids list here:

diff --git a/src/backend/commands/tablecmds.c 
b/src/backend/commands/tablecmds.c
index 6a128f7bd4e..4254654cc24 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -20122,6 +20122,7 @@ ATExecAttachPartition(List **wqueue, Relation 
rel, PartitionCmd *cmd,
relname)));
                         }
                 }
+               list_free(puboids);
         }

         /*


-- 
With best regards,
Sergey Tatarintsev,
PostgresPro