Feedback-ID: ie0a040ee:Fastmail
Message-ID: <dfd66b40-4b8d-4239-bbca-01d3e431ca5b@eisentraut.org>
Date: Fri, 2 Aug 2024 20:45:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Official devcontainer config
To: Andrew Dunstan <andrew@dunslane.net>, Junwang Zhao <zhjwpku@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andrey Borodin <amborodin86@gmail.com>,
 Jelte Fennema-Nio <postgres@jeltef.nl>
References: <CAEG8a3K_mZsBZ60smh4FM4Dk9cazAUmM72iXdFKEHgthZnaHcw@mail.gmail.com>
 <57c12c52-123c-4a13-a258-02639473fa17@dunslane.net>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <57c12c52-123c-4a13-a258-02639473fa17@dunslane.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/dfd66b40-4b8d-4239-bbca-01d3e431ca5b%40eisentraut.org>
Precedence: bulk

On 01.08.24 23:38, Andrew Dunstan wrote:
> Not totally opposed, and I will probably give it a try very soon, but 
> I'm wondering if this really needs to go in the core repo. We've 
> generally shied away from doing much in the way of editor / devenv 
> support, trying to be fairly agnostic. It's true we carry .dir-locals.el 
> and .editorconfig, so that's not entirely true, but those are really 
> just about supporting our indentation etc. standards.

Yeah, the editor support in the tree ought to be minimal and factual, 
based on coding standards and widely recognized best practices, not a 
collection of one person's favorite aliases and scripts.  If the scripts 
are good, let's look at them and maybe put them under src/tools/ for 
everyone to use.  But a lot of this looks like it will requite active 
maintenance if output formats or node formats or build targets etc. 
change.  And other things require specific local paths.  That's fine for 
a local script or something, but not for a mainline tool that the 
community will need to maintain.

I suggest to start with a very minimal configuration. What are the 
settings that absolute everyone will need, maybe to set indentation 
style or something.