MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 16 Aug 2017 18:44:18 +0300
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>, Fabien COELHO
 <coelho@cri.ensmp.fr>, Kevin Grittner <kgrittn@gmail.com>, Alvaro Herrera
 <alvherre@2ndquadrant.com>, Thomas Munro <thomas.munro@enterprisedb.com>,
 Robert Haas <robertmhaas@gmail.com>, Alexander Korotkov
 <a.korotkov@postgrespro.ru>
Subject: Re: WIP Patch: Pgbench Serialization and deadlock errors
Organization: Postgres Professional
In-Reply-To: <20170811195047.gvpn2agbjrnrvdkg@alap3.anarazel.de>
References: <f69d534dfada1fdb4767496b7ffc007f@postgrespro.ru>
 <alpine.DEB.2.20.1707121142300.12795@lancre>
 <6ce8613f061001105654673506348c13@postgrespro.ru>
 <alpine.DEB.2.20.1707131818200.20175@lancre>
 <b8aa946758db5d8f1cd3a771e5733d69@postgrespro.ru>
 <alpine.DEB.2.20.1707141344070.20175@lancre>
 <0e7afb8c40e9241510947332be8e2ed2@postgrespro.ru>
 <alpine.DEB.2.20.1707141637300.7871@lancre>
 <5c9f781b61d2292fcbe16ab4ff51499a@postgrespro.ru>
 <1d516bfc555ddde18adbf14bd474f0a2@postgrespro.ru>
 <20170811195047.gvpn2agbjrnrvdkg@alap3.anarazel.de>
Message-ID: <e0169b5d51fe51a22105c44e8a246acc@postgrespro.ru>
User-Agent: Roundcube Webmail/1.2.4
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

> Hi,

Hello!

> Just had a need for this feature, and took this to a short test
> drive. So some comments:
> - it'd be useful to display a retry percentage of all transactions,
>   similar to what's displayed for failed transactions.

> - it'd be useful to also conveniently display the number of retried
>   transactions, rather than the total number of retries.

Ok!

> - it appears that we now unconditionally do not disregard a connection
>   after a serialization / deadlock failure. Good. But that's useful far
>   beyond just deadlocks / serialization errors, and should probably be 
> exposed.

I agree that it will be useful. But how do you propose to print the 
results if there are many types of errors? I'm afraid that the progress 
report can be very long although it is expected that it will be rather 
short [1]. The per statement report can also be very long..

> Nice feature!

Thanks and thank you for your comments :)

[1] 
https://www.postgresql.org/message-id/alpine.DEB.2.20.1707121142300.12795%40lancre

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers