Subject: Re: [PATCH v2] Allow COPY "text" to output a header and add header
 matching mode to COPY FROM
To: =?UTF-8?Q?R=c3=a9mi_Lapeyre?= <remi.lapeyre@lenstra.fr>,
 pgsql-hackers@postgresql.org
References: <4E31E7AA-BFC6-47ED-90E1-3838E4D1F4FF@yesql.se>
 <20200708114501.56681-1-remi.lapeyre@lenstra.fr>
Cc: =?UTF-8?Q?R=c3=a9mi_Lapeyre?= <remi.lapeyre@henki.fr>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <e03f6493-f00d-9b7b-ce37-0bde6b2fed78@2ndquadrant.com>
Date: Fri, 10 Jul 2020 13:34:16 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200708114501.56681-1-remi.lapeyre@lenstra.fr>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2020-07-08 13:45, Rémi Lapeyre wrote:
> Hi, here's a new version of the patch that should apply cleanly. I'll monitor
> the status on http://cfbot.cputube.org/

It's hard to find an explanation what this patch actually does.  I don't 
want to have to go through threads dating back 4 months to determine 
what was discussed and what was actually implemented.  Since you're 
already using git format-patch, just add something to the commit message.

It appears that these are really two separate features, so perhaps they 
should be two patches.

Also, the new header matching mode could probably use more than one line 
of documentation.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services