Content-Type: multipart/mixed; boundary="------------KjmE1CkfuyC9nKt0FNBYUjRa"
Message-ID: <e0508305-bc6a-417c-b969-36564d632f9e@iki.fi>
Date: Tue, 3 Feb 2026 21:08:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup
To: Amit Kapila <amit.kapila16@gmail.com>,
 "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: shveta malik <shveta.malik@gmail.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>,
 Doruk Yilmaz <doruk@mixrank.com>
References: <CAJpy0uB19aKEgVgh8gwzj87NUyDgOf01boa-6xJZK+nhb=3W4g@mail.gmail.com>
 <CAA4eK1+h4mOvRqRaGfUtSgZuBhzWWmrBcY3jQ4DDV=cEJ4dwnQ@mail.gmail.com>
 <TY7PR01MB145543A74547443E49E4993E7F58EA@TY7PR01MB14554.jpnprd01.prod.outlook.com>
 <CAJpy0uD6D294d=Hq4oROmtKAew5DfKERNxs=DsAwUFBFF2kERg@mail.gmail.com>
 <TY7PR01MB14554FB7D02601425DE3752DEF58FA@TY7PR01MB14554.jpnprd01.prod.outlook.com>
 <CAA4eK1JvYROk5usAX0Uy=00VACB=w1rvUcyoKvRuke5EMfmi3Q@mail.gmail.com>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <CAA4eK1JvYROk5usAX0Uy=00VACB=w1rvUcyoKvRuke5EMfmi3Q@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/e0508305-bc6a-417c-b969-36564d632f9e%40iki.fi>
Precedence: bulk

This is a multi-part message in MIME format.
--------------KjmE1CkfuyC9nKt0FNBYUjRa
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

The new error message is not great:

postgres=# select pg_replication_origin_session_setup('myorigin', 12345678);
ERROR:  could not find replication state slot for replication origin 
with OID 1 which was acquired by 12345678

Firstly, replication origin is not an OID. Secondly, it's a little 
confusing because the "replication state slot" is in fact present. 
However, it's currently inactive, i.e. not "acquired" by the given PID.

I propose to change that to:

postgres=# select pg_replication_origin_session_setup('myorigin', 12345678);
ERROR:  replication origin with ID 1 is not active for PID 12345678

That's more in line with this neighboring message:

ERROR:  replication origin with ID 1 is already active for PID 701228


I also wonder if the error code is appropriate. That error uses 
ERRCODE_OBJECT_IN_USE, but if the problem is that the origin is 
currently *not* active, that seems backwards. I didn't change that in 
the attached patch, but it's something to think about.


The second patch rearranges the if-else statements to check those 
conditions. I found the current logic hard to follow, this makes them 
feel more natural, in my opinion at least. It has one user-visible 
effect: If you call the function with acquired_pid != 0 and the origin 
has no state slot, *and* there are no free slots, you previously got 
this error:

postgres=# select pg_replication_origin_session_setup('other', 123);
ERROR:  could not find free replication state slot for replication 
origin with ID 2
HINT:  Increase "max_active_replication_origins" and try again.

Now you get this:

postgres=# select pg_replication_origin_session_setup('other', 123);
ERROR:  cannot use PID 123 for inactive replication origin with ID 2

Both error messages are more or less appropriate in that situation, but 
I think the new behavior is slightly better. The fact that the origin is 
inactive feels like the bigger problem here.

- Heikki

--------------KjmE1CkfuyC9nKt0FNBYUjRa
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Improve-error-message.patch"
Content-Disposition: attachment; filename="0001-Improve-error-message.patch"
Content-Transfer-Encoding: base64

RnJvbSAyMzNlNTRiMGI0ZGJkYWE4NDkxMGZiN2NjNDUzODc3MzkxODY1ODM5IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZWlra2kgTGlubmFrYW5nYXMgPGhlaWtraS5saW5u
YWthbmdhc0Bpa2kuZmk+CkRhdGU6IFR1ZSwgMyBGZWIgMjAyNiAyMDozMzoyMyArMDIwMApT
dWJqZWN0OiBbUEFUQ0ggMS8yXSBJbXByb3ZlIGVycm9yIG1lc3NhZ2UKCi0gVXNlIHRoZSBz
YW1lIHdvcmRpbmdzIGFuZCB0ZXJtcyBhcyB0aGUgbmVpZ2hib3JpbmcgbWVzc2FnZXMKLSBV
c2UgJ2N1cnN0YXRlLT5yb2lkZW50JyBpbnN0ZWFkIG9mICdub2RlJy4gV2UndmUgY2hlY2tl
ZCB0aGF0IHRoZXkncmUKICBlcXVhbCwgYnV0IGxldCdzIGJlIGNvbnNpc3RlbnQgd2l0aCB0
aGUgbmVpZ2hib3JpbmcgZXJlcG9ydHMoKS4KLS0tCiBzcmMvYmFja2VuZC9yZXBsaWNhdGlv
bi9sb2dpY2FsL29yaWdpbi5jIHwgNCArKy0tCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRp
b25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxp
Y2F0aW9uL2xvZ2ljYWwvb3JpZ2luLmMgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dp
Y2FsL29yaWdpbi5jCmluZGV4IGMzMjcxYTZmZDBlLi5lYzA0MGEwMzlkMyAxMDA2NDQKLS0t
IGEvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC9vcmlnaW4uYworKysgYi9zcmMv
YmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL29yaWdpbi5jCkBAIC0xMTk3LDggKzExOTcs
OCBAQCByZXBsb3JpZ2luX3Nlc3Npb25fc2V0dXAoUmVwbE9yaWdpbklkIG5vZGUsIGludCBh
Y3F1aXJlZF9ieSkKIAkJewogCQkJZXJlcG9ydChFUlJPUiwKIAkJCQkJKGVycmNvZGUoRVJS
Q09ERV9PQkpFQ1RfSU5fVVNFKSwKLQkJCQkJIGVycm1zZygiY291bGQgbm90IGZpbmQgcmVw
bGljYXRpb24gc3RhdGUgc2xvdCBmb3IgcmVwbGljYXRpb24gb3JpZ2luIHdpdGggT0lEICV1
IHdoaWNoIHdhcyBhY3F1aXJlZCBieSAlZCIsCi0JCQkJCQkJbm9kZSwgYWNxdWlyZWRfYnkp
KSk7CisJCQkJCSBlcnJtc2coInJlcGxpY2F0aW9uIG9yaWdpbiB3aXRoIElEICVkIGlzIG5v
dCBhY3RpdmUgZm9yIFBJRCAlZCIsCisJCQkJCQkJY3Vyc3RhdGUtPnJvaWRlbnQsIGFjcXVp
cmVkX2J5KSkpOwogCQl9CiAKIAkJLyoKLS0gCjIuNDcuMwoK
--------------KjmE1CkfuyC9nKt0FNBYUjRa
Content-Type: text/x-patch; charset=UTF-8;
 name="0002-Rearrange-the-checks-in-replorigin_session_setup.patch"
Content-Disposition: attachment;
 filename*0="0002-Rearrange-the-checks-in-replorigin_session_setup.patch"
Content-Transfer-Encoding: base64

RnJvbSA1N2IyZTc4OWI0MDI5N2JhMjk5YWYwNjg4MmJkNDA3NjU4NjMwMGRhIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZWlra2kgTGlubmFrYW5nYXMgPGhlaWtraS5saW5u
YWthbmdhc0Bpa2kuZmk+CkRhdGU6IFR1ZSwgMyBGZWIgMjAyNiAyMDoyOTo1NCArMDIwMApT
dWJqZWN0OiBbUEFUQ0ggMi8yXSBSZWFycmFuZ2UgdGhlIGNoZWNrcyBpbiByZXBsb3JpZ2lu
X3Nlc3Npb25fc2V0dXAoKQoKTWFrZXMgaXQgZWFzaWVyIHRvIGZvbGxvdyB0aGUgbG9naWMu
Ci0tLQogc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC9vcmlnaW4uYyB8IDczICsr
KysrKysrKysrKystLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQxIGluc2VydGlvbnMo
KyksIDMyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0
aW9uL2xvZ2ljYWwvb3JpZ2luLmMgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9sb2dpY2Fs
L29yaWdpbi5jCmluZGV4IGVjMDQwYTAzOWQzLi5jYjE4YjRiNjY4NiAxMDA2NDQKLS0tIGEv
c3JjL2JhY2tlbmQvcmVwbGljYXRpb24vbG9naWNhbC9vcmlnaW4uYworKysgYi9zcmMvYmFj
a2VuZC9yZXBsaWNhdGlvbi9sb2dpY2FsL29yaWdpbi5jCkBAIC0xMTg1LDU1ICsxMTg1LDY0
IEBAIHJlcGxvcmlnaW5fc2Vzc2lvbl9zZXR1cChSZXBsT3JpZ2luSWQgbm9kZSwgaW50IGFj
cXVpcmVkX2J5KQogCQlpZiAoY3Vyc3RhdGUtPnJvaWRlbnQgIT0gbm9kZSkKIAkJCWNvbnRp
bnVlOwogCi0JCWVsc2UgaWYgKGN1cnN0YXRlLT5hY3F1aXJlZF9ieSAhPSAwICYmIGFjcXVp
cmVkX2J5ID09IDApCisJCWlmIChhY3F1aXJlZF9ieSA9PSAwKQogCQl7Ci0JCQllcmVwb3J0
KEVSUk9SLAotCQkJCQkoZXJyY29kZShFUlJDT0RFX09CSkVDVF9JTl9VU0UpLAotCQkJCQkg
ZXJybXNnKCJyZXBsaWNhdGlvbiBvcmlnaW4gd2l0aCBJRCAlZCBpcyBhbHJlYWR5IGFjdGl2
ZSBmb3IgUElEICVkIiwKLQkJCQkJCQljdXJzdGF0ZS0+cm9pZGVudCwgY3Vyc3RhdGUtPmFj
cXVpcmVkX2J5KSkpOworCQkJLyogV2l0aCBhY3F1aXJlZF9ieSA9PSAwLCB3ZSBuZWVkIHRo
ZSBvcmlnaW4gdG8gYmUgZnJlZSAqLworCQkJaWYgKGN1cnN0YXRlLT5hY3F1aXJlZF9ieSAh
PSAwKQorCQkJCWVyZXBvcnQoRVJST1IsCisJCQkJCQkoZXJyY29kZShFUlJDT0RFX09CSkVD
VF9JTl9VU0UpLAorCQkJCQkJIGVycm1zZygicmVwbGljYXRpb24gb3JpZ2luIHdpdGggSUQg
JWQgaXMgYWxyZWFkeSBhY3RpdmUgZm9yIFBJRCAlZCIsCisJCQkJCQkJCWN1cnN0YXRlLT5y
b2lkZW50LCBjdXJzdGF0ZS0+YWNxdWlyZWRfYnkpKSk7CisKKwkJCWlmIChjdXJzdGF0ZS0+
cmVmY291bnQgPiAwKQorCQkJeworCQkJCS8qCisJCQkJICogVGhlIG9yaWdpbiBpcyBpbiB1
c2UsIGJ1dCBQSUQgaXMgbm90IHJlY29yZGVkLiBUaGlzIGNhbgorCQkJCSAqIGhhcHBlbiBp
ZiB0aGUgcHJvY2VzcyB0aGF0IG9yaWdpbmFsbHkgYWNxdWlyZWQgdGhlIG9yaWdpbgorCQkJ
CSAqIGV4aXRlZCB3aXRob3V0IHJlbGVhc2luZyBpdC4gVG8gZW5zdXJlIGNvcnJlY3RuZXNz
LCBvdGhlcgorCQkJCSAqIHByb2Nlc3NlcyBjYW5ub3QgYWNxdWlyZSB0aGUgb3JpZ2luIHVu
dGlsIGFsbCBwcm9jZXNzZXMKKwkJCQkgKiBjdXJyZW50bHkgdXNpbmcgaXQgaGF2ZSByZWxl
YXNlZCBpdC4KKwkJCQkgKi8KKwkJCQllcmVwb3J0KEVSUk9SLAorCQkJCQkJKGVycmNvZGUo
RVJSQ09ERV9PQkpFQ1RfSU5fVVNFKSwKKwkJCQkJCSBlcnJtc2coInJlcGxpY2F0aW9uIG9y
aWdpbiB3aXRoIElEICVkIGlzIGFscmVhZHkgYWN0aXZlIGluIGFub3RoZXIgcHJvY2VzcyIs
CisJCQkJCQkJCWN1cnN0YXRlLT5yb2lkZW50KSkpOworCQkJfQogCQl9Ci0KLQkJZWxzZSBp
ZiAoY3Vyc3RhdGUtPmFjcXVpcmVkX2J5ICE9IGFjcXVpcmVkX2J5KQorCQllbHNlCiAJCXsK
LQkJCWVyZXBvcnQoRVJST1IsCi0JCQkJCShlcnJjb2RlKEVSUkNPREVfT0JKRUNUX0lOX1VT
RSksCi0JCQkJCSBlcnJtc2coInJlcGxpY2F0aW9uIG9yaWdpbiB3aXRoIElEICVkIGlzIG5v
dCBhY3RpdmUgZm9yIFBJRCAlZCIsCi0JCQkJCQkJY3Vyc3RhdGUtPnJvaWRlbnQsIGFjcXVp
cmVkX2J5KSkpOworCQkJLyoKKwkJCSAqIFdpdGggYWNxdWlyZWRfYnkgIT0gMCwgd2UgbmVl
ZCB0aGUgb3JpZ2luIHRvIGJlIGFjdGl2ZSBieSB0aGUKKwkJCSAqIGdpdmVuIFBJRAorCQkJ
ICovCisJCQlpZiAoY3Vyc3RhdGUtPmFjcXVpcmVkX2J5ICE9IGFjcXVpcmVkX2J5KQorCQkJ
CWVyZXBvcnQoRVJST1IsCisJCQkJCQkoZXJyY29kZShFUlJDT0RFX09CSkVDVF9JTl9VU0Up
LAorCQkJCQkJIGVycm1zZygicmVwbGljYXRpb24gb3JpZ2luIHdpdGggSUQgJWQgaXMgbm90
IGFjdGl2ZSBmb3IgUElEICVkIiwKKwkJCQkJCQkJY3Vyc3RhdGUtPnJvaWRlbnQsIGFjcXVp
cmVkX2J5KSkpOwogCQl9CiAKLQkJLyoKLQkJICogVGhlIG9yaWdpbiBpcyBpbiB1c2UsIGJ1
dCBQSUQgaXMgbm90IHJlY29yZGVkLiBUaGlzIGNhbiBoYXBwZW4gaWYKLQkJICogdGhlIHBy
b2Nlc3MgdGhhdCBvcmlnaW5hbGx5IGFjcXVpcmVkIHRoZSBvcmlnaW4gZXhpdGVkIHdpdGhv
dXQKLQkJICogcmVsZWFzaW5nIGl0LiBUbyBlbnN1cmUgY29ycmVjdG5lc3MsIG90aGVyIHBy
b2Nlc3NlcyBjYW5ub3QgYWNxdWlyZQotCQkgKiB0aGUgb3JpZ2luIHVudGlsIGFsbCBwcm9j
ZXNzZXMgY3VycmVudGx5IHVzaW5nIGl0IGhhdmUgcmVsZWFzZWQgaXQuCi0JCSAqLwotCQll
bHNlIGlmIChjdXJzdGF0ZS0+YWNxdWlyZWRfYnkgPT0gMCAmJiBjdXJzdGF0ZS0+cmVmY291
bnQgPiAwKQotCQkJZXJlcG9ydChFUlJPUiwKLQkJCQkJKGVycmNvZGUoRVJSQ09ERV9PQkpF
Q1RfSU5fVVNFKSwKLQkJCQkJIGVycm1zZygicmVwbGljYXRpb24gb3JpZ2luIHdpdGggSUQg
JWQgaXMgYWxyZWFkeSBhY3RpdmUgaW4gYW5vdGhlciBwcm9jZXNzIiwKLQkJCQkJCQljdXJz
dGF0ZS0+cm9pZGVudCkpKTsKLQogCQkvKiBvaywgZm91bmQgc2xvdCAqLwogCQlzZXNzaW9u
X3JlcGxpY2F0aW9uX3N0YXRlID0gY3Vyc3RhdGU7CiAJCWJyZWFrOwogCX0KIAotCi0JaWYg
KHNlc3Npb25fcmVwbGljYXRpb25fc3RhdGUgPT0gTlVMTCAmJiBmcmVlX3Nsb3QgPT0gLTEp
Ci0JCWVyZXBvcnQoRVJST1IsCi0JCQkJKGVycmNvZGUoRVJSQ09ERV9DT05GSUdVUkFUSU9O
X0xJTUlUX0VYQ0VFREVEKSwKLQkJCQkgZXJybXNnKCJjb3VsZCBub3QgZmluZCBmcmVlIHJl
cGxpY2F0aW9uIHN0YXRlIHNsb3QgZm9yIHJlcGxpY2F0aW9uIG9yaWdpbiB3aXRoIElEICVk
IiwKLQkJCQkJCW5vZGUpLAotCQkJCSBlcnJoaW50KCJJbmNyZWFzZSBcIm1heF9hY3RpdmVf
cmVwbGljYXRpb25fb3JpZ2luc1wiIGFuZCB0cnkgYWdhaW4uIikpKTsKLQllbHNlIGlmIChz
ZXNzaW9uX3JlcGxpY2F0aW9uX3N0YXRlID09IE5VTEwpCisJaWYgKHNlc3Npb25fcmVwbGlj
YXRpb25fc3RhdGUgPT0gTlVMTCkKIAl7Ci0JCWlmIChhY3F1aXJlZF9ieSkKKwkJaWYgKGFj
cXVpcmVkX2J5ICE9IDApCiAJCQllcmVwb3J0KEVSUk9SLAogCQkJCQkoZXJyY29kZShFUlJD
T0RFX09CSkVDVF9OT1RfSU5fUFJFUkVRVUlTSVRFX1NUQVRFKSwKIAkJCQkJIGVycm1zZygi
Y2Fubm90IHVzZSBQSUQgJWQgZm9yIGluYWN0aXZlIHJlcGxpY2F0aW9uIG9yaWdpbiB3aXRo
IElEICVkIiwKIAkJCQkJCQlhY3F1aXJlZF9ieSwgbm9kZSkpKTsKIAogCQkvKiBpbml0aWFs
aXplIG5ldyBzbG90ICovCisJCWlmIChmcmVlX3Nsb3QgPT0gLTEpCisJCQllcmVwb3J0KEVS
Uk9SLAorCQkJCQkoZXJyY29kZShFUlJDT0RFX0NPTkZJR1VSQVRJT05fTElNSVRfRVhDRUVE
RUQpLAorCQkJCQkgZXJybXNnKCJjb3VsZCBub3QgZmluZCBmcmVlIHJlcGxpY2F0aW9uIHN0
YXRlIHNsb3QgZm9yIHJlcGxpY2F0aW9uIG9yaWdpbiB3aXRoIElEICVkIiwKKwkJCQkJCQlu
b2RlKSwKKwkJCQkJIGVycmhpbnQoIkluY3JlYXNlIFwibWF4X2FjdGl2ZV9yZXBsaWNhdGlv
bl9vcmlnaW5zXCIgYW5kIHRyeSBhZ2Fpbi4iKSkpOworCiAJCXNlc3Npb25fcmVwbGljYXRp
b25fc3RhdGUgPSAmcmVwbGljYXRpb25fc3RhdGVzW2ZyZWVfc2xvdF07CiAJCUFzc2VydCgh
WExvZ1JlY1B0cklzVmFsaWQoc2Vzc2lvbl9yZXBsaWNhdGlvbl9zdGF0ZS0+cmVtb3RlX2xz
bikpOwogCQlBc3NlcnQoIVhMb2dSZWNQdHJJc1ZhbGlkKHNlc3Npb25fcmVwbGljYXRpb25f
c3RhdGUtPmxvY2FsX2xzbikpOwotLSAKMi40Ny4zCgo=

--------------KjmE1CkfuyC9nKt0FNBYUjRa--