MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_7130c7777b1526c1745c25927c5b7a5d"
Content-Transfer-Encoding: 7bit
Date: Thu, 15 May 2025 17:52:06 +0900
From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Assertion failure in smgr.c when using pg_prewarm with partitioned
 tables
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <e082e6027610fd0a4091ae6d033aa117@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/e082e6027610fd0a4091ae6d033aa117%40oss.nttdata.com>
Precedence: bulk

--=_7130c7777b1526c1745c25927c5b7a5d
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

Hi,

I encountered an assertion failure when a partitioned table is specified
as an argument to pg_prewarm. Below are the steps to reproduce the 
issue:

$ pgbench -i -s 1 --partitions=3
$ psql <<EOF
CREATE EXTENSION pg_prewarm;
SELECT pg_prewarm('pgbench_accounts');
EOF

The following assertion failure occurs:

TRAP: failed Assert("RelFileNumberIsValid(rlocator.relNumber)"), File: 
"smgr.c", Line: 246, PID: 1246282
postgres: ikeda postgres [local] 
SELECT(ExceptionalCondition+0xbb)[0x55edd16725c1]
postgres: ikeda postgres [local] SELECT(smgropen+0x5e)[0x55edd145c1ff]


It looks like this may have been overlooked in commit 049ef33.
What do you think?

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION
--=_7130c7777b1526c1745c25927c5b7a5d
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=v1-0001-Fix-assertion-failure-when-pg_prewarm-is-used-on-.patch
Content-Disposition: attachment;
 filename=v1-0001-Fix-assertion-failure-when-pg_prewarm-is-used-on-.patch;
 size=2612

RnJvbSAzYzI3MTUyNzE5ZjNiYmM4NGQ2MWRjMTM2NTg0ZjUzMGE3NWU2ZGExIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXNhaGlybyBJa2VkYSA8aWtlZGFtc2hAb3NzLm50dGRhdGEu
Y29tPgpEYXRlOiBUaHUsIDE1IE1heSAyMDI1IDE3OjI2OjI3ICswOTAwClN1YmplY3Q6IFtQQVRD
SCB2MV0gRml4IGFzc2VydGlvbiBmYWlsdXJlIHdoZW4gcGdfcHJld2FybSBpcyB1c2VkIG9uIGEK
IHBhcnRpdGlvbmVkIHRhYmxlCgpUaGlzIGlzc3VlIHdhcyBpbnRyb2R1Y2VkIGJ5IGNvbW1pdCAw
NDllZjMzLgoKU3BlY2lmeWluZyBhIHBhcnRpdGlvbmVkIHRhYmxlIGFzIGFuIGFyZ3VtZW50IHRv
IHBnX3ByZXdhcm0KY291bGQgdHJpZ2dlciBhbiBhc3NlcnRpb24gZmFpbHVyZToKCiBGYWlsZWQg
QXNzZXJ0KCJSZWxGaWxlTnVtYmVySXNWYWxpZChybG9jYXRvci5yZWxOdW1iZXIpIikKClRoaXMg
Zml4IGVuc3VyZXMgdGhhdCBzdWNoIGNhc2VzIGFyZSBoYW5kbGVkIGFwcHJvcHJpYXRlbHkuCi0t
LQogY29udHJpYi9wZ19wcmV3YXJtL3BnX3ByZXdhcm0uYyAgIHwgIDMgKystCiBjb250cmliL3Bn
X3ByZXdhcm0vdC8wMDFfYmFzaWMucGwgfCAxMSArKysrKysrKysrLQogMiBmaWxlcyBjaGFuZ2Vk
LCAxMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2NvbnRyaWIv
cGdfcHJld2FybS9wZ19wcmV3YXJtLmMgYi9jb250cmliL3BnX3ByZXdhcm0vcGdfcHJld2FybS5j
CmluZGV4IDUwODA4NTY5YmQ3Li45NGEzNjc5NTEzMCAxMDA2NDQKLS0tIGEvY29udHJpYi9wZ19w
cmV3YXJtL3BnX3ByZXdhcm0uYworKysgYi9jb250cmliL3BnX3ByZXdhcm0vcGdfcHJld2FybS5j
CkBAIC0xMTMsNyArMTEzLDggQEAgcGdfcHJld2FybShQR19GVU5DVElPTl9BUkdTKQogCQlhY2xj
aGVja19lcnJvcihhY2xyZXN1bHQsIGdldF9yZWxraW5kX29ianR5cGUocmVsLT5yZF9yZWwtPnJl
bGtpbmQpLCBnZXRfcmVsX25hbWUocmVsT2lkKSk7CiAKIAkvKiBDaGVjayB0aGF0IHRoZSBmb3Jr
IGV4aXN0cy4gKi8KLQlpZiAoIXNtZ3JleGlzdHMoUmVsYXRpb25HZXRTbWdyKHJlbCksIGZvcmtO
dW1iZXIpKQorCWlmICghUmVsRmlsZU51bWJlcklzVmFsaWQocmVsLT5yZF9sb2NhdG9yLnJlbE51
bWJlcikgfHwKKwkJCSFzbWdyZXhpc3RzKFJlbGF0aW9uR2V0U21ncihyZWwpLCBmb3JrTnVtYmVy
KSkKIAkJZXJlcG9ydChFUlJPUiwKIAkJCQkoZXJyY29kZShFUlJDT0RFX0lOVkFMSURfUEFSQU1F
VEVSX1ZBTFVFKSwKIAkJCQkgZXJybXNnKCJmb3JrIFwiJXNcIiBkb2VzIG5vdCBleGlzdCBmb3Ig
dGhpcyByZWxhdGlvbiIsCmRpZmYgLS1naXQgYS9jb250cmliL3BnX3ByZXdhcm0vdC8wMDFfYmFz
aWMucGwgYi9jb250cmliL3BnX3ByZXdhcm0vdC8wMDFfYmFzaWMucGwKaW5kZXggMGE4MjU5ZDM2
NzguLjU3YTAxMzQ0NTRiIDEwMDY0NAotLS0gYS9jb250cmliL3BnX3ByZXdhcm0vdC8wMDFfYmFz
aWMucGwKKysrIGIvY29udHJpYi9wZ19wcmV3YXJtL3QvMDAxX2Jhc2ljLnBsCkBAIC0yMyw3ICsy
MywxMCBAQCAkbm9kZS0+c3RhcnQ7CiAkbm9kZS0+c2FmZV9wc3FsKCJwb3N0Z3JlcyIsCiAJCSJD
UkVBVEUgRVhURU5TSU9OIHBnX3ByZXdhcm07XG4iCiAJICAuICJDUkVBVEUgVEFCTEUgdGVzdChj
MSBpbnQpO1xuIgotCSAgLiAiSU5TRVJUIElOVE8gdGVzdCBTRUxFQ1QgZ2VuZXJhdGVfc2VyaWVz
KDEsIDEwMCk7Iik7CisJICAuICJJTlNFUlQgSU5UTyB0ZXN0IFNFTEVDVCBnZW5lcmF0ZV9zZXJp
ZXMoMSwgMTAwKTtcbiIKKwkgIC4gIkNSRUFURSBUQUJMRSB0ZXN0X3BhcnQoYzEgaW50KSBQQVJU
SVRJT04gQlkgUkFOR0UgKGMxKTtcbiIKKwkgIC4gIkNSRUFURSBUQUJMRSB0ZXN0X3BhcnQxIFBB
UlRJVElPTiBPRiB0ZXN0X3BhcnQgRk9SIFZBTFVFUyBGUk9NICgxKSBUTyAoMTAwMCk7XG4iCisJ
ICAuICJJTlNFUlQgSU5UTyB0ZXN0X3BhcnQgU0VMRUNUIGdlbmVyYXRlX3NlcmllcygxLCAxMDAp
OyIpOwogCiAjIHRlc3QgcmVhZCBtb2RlCiBteSAkcmVzdWx0ID0KQEAgLTQyLDYgKzQ1LDEyIEBA
IG9rKCAoICAgICAgICAkc3Rkb3V0ID1+IHFyL15bMS05XVswLTldKiQvCiAJCSAgb3IgJHN0ZGVy
ciA9fiBxci9wcmVmZXRjaCBpcyBub3Qgc3VwcG9ydGVkIGJ5IHRoaXMgYnVpbGQvKSwKIAkncHJl
ZmV0Y2ggbW9kZSBzdWNjZWVkZWQnKTsKIAorIyB0ZXN0IHBhcnRpdGlvbiB0YWJsZQorKCRjbWRy
ZXQsICRzdGRvdXQsICRzdGRlcnIpID0KKyAgJG5vZGUtPnBzcWwoInBvc3RncmVzIiwgIlNFTEVD
VCBwZ19wcmV3YXJtKCd0ZXN0X3BhcnQnLCAnYnVmZmVyJyk7Iik7CitvayggJHN0ZGVyciA9fiAv
Zm9yayAibWFpbiIgZG9lcyBub3QgZXhpc3QgZm9yIHRoaXMgcmVsYXRpb24vLAorCSdkZXRlY3Rl
ZCB0aGUgZm9yayBkb2VzIG5vdCBleGlzdCcpOworCiAjIHRlc3QgYXV0b3ByZXdhcm1fZHVtcF9u
b3coKQogJHJlc3VsdCA9ICRub2RlLT5zYWZlX3BzcWwoInBvc3RncmVzIiwgIlNFTEVDVCBhdXRv
cHJld2FybV9kdW1wX25vdygpOyIpOwogbGlrZSgkcmVzdWx0LCBxci9eWzEtOV1bMC05XSokLywg
J2F1dG9wcmV3YXJtX2R1bXBfbm93IHN1Y2NlZWRlZCcpOwotLSAKMi4zNC4xCgo=
--=_7130c7777b1526c1745c25927c5b7a5d--