Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sdsfl-001puQ-Tt for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Aug 2024 14:38:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sdsfj-004R52-Lb for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Aug 2024 14:38:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sdsfj-004R4u-2b for pgsql-hackers@lists.postgresql.org; Tue, 13 Aug 2024 14:38:51 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sdsfc-004fLl-H3 for pgsql-hackers@postgresql.org; Tue, 13 Aug 2024 14:38:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1723559923; bh=zeeU9bU15upqfwweoYZLevPQ7Uqq6Y3+7yG7LwXnkuY=; h=Message-ID:Date:User-Agent:To:From:Subject:From; b=tOLVT9tqdwLvLTwxnJj8Zjy873G7CECK/so3GB9ZgDZeiDvxWkQvQffaRQ69ITfAw jPFQ0rwoynkuQHDDp5XeuHm+tfPlVqzui10DOvfCbZYXtB1YYsmBeXkWkGQF+TNe9n V8bQNhOEnbgFE8Ooygp4YPZBRmOSVo+7RR1RxrqPPAzqU6tQcDlJHToq2uieqcLH4r mL0Vim4fdRYIJJ2sAug019znE3ILbAV/VVFizC5LI1nrfu8uYljxZ7ZvgurLTm/0pS m6xQV6wap37JtaY7+IYRIwGCzF6xg+5A0GuOdi0I9z5fRs04fl4+TjJd1i14mjKXPJ kodwticr3ZITg== Received: from [10.4.13.70] (unknown [93.174.131.141]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: s.kopikova@postgrespro.ru) by mail.postgrespro.ru (Postfix/465) with ESMTPSA id 2CB8B60391 for ; Tue, 13 Aug 2024 17:38:43 +0300 (MSK) Content-Type: multipart/mixed; boundary="------------187AJgikZzVIzPy0cHuTyJl7" Message-ID: Date: Tue, 13 Aug 2024 17:38:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pgsql-hackers@postgresql.org From: Sofia Kopikova Subject: Apply PGDLLIMPORT markings to some GUC variables X-KSMG-AntiPhishing: NotDetected, bases: 2024/08/13 12:30:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2024/08/13 06:37:00 #26296570 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------187AJgikZzVIzPy0cHuTyJl7 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi hackers, I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to header files. According to the commit message in 8ec569479, all variables in header files must be marked with PGDLLIMPORT, am I right? I've made a patch that adds missing PGDLLIMPORTs, please, take a look. -- Best regards, Sofia Kopikova Postgres Professional: http://www.postgrespro.com --------------187AJgikZzVIzPy0cHuTyJl7 Content-Type: text/x-patch; charset=UTF-8; name="0001-Apply-PGDLLIMPORT-markings-to-some-GUC-variables.patch" Content-Disposition: attachment; filename*0="0001-Apply-PGDLLIMPORT-markings-to-some-GUC-variables.patch" Content-Transfer-Encoding: base64 RnJvbSA2MDNiMDQzM2I5NTM4NDIzYTMyNGFlOTgwZTBhMTlkN2NhYWYyMjJlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBTb2ZpYSBLb3Bpa292YSA8cy5rb3Bpa292YUBwb3N0 Z3Jlc3Byby5ydT4KRGF0ZTogVHVlLCAxMyBBdWcgMjAyNCAxNjowNToxMyArMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIEFwcGx5IFBHRExMSU1QT1JUIG1hcmtpbmdzIHRvIHNvbWUgR1VDIHZh cmlhYmxlcwoKQWNjb3JkaW5nIHRvIHRoZSBjb21taXQgbWVzc2FnZSBpbiA4ZWM1Njk0Nzks IHdlIG11c3QgaGF2ZSBhbGwgdmFyaWFibGVzCmluIGhlYWRlciBmaWxlcyBtYXJrZWQgd2l0 aCBQR0RMTElNUE9SVC4gSW4gY29tbWl0IGQzY2M1ZmZlODFmNiBzb21lCnZhcmlhYmxlcyB3 ZXJlIG1vdmVkIGZyb20gbGF1bmNoX2JhY2tlbmQuYyBmaWxlIHRvIHNldmVyYWwgaGVhZGVy IGZpbGVzLgoKVGhpcyBhZGRzIFBHRExMSU1QT1JUIHRvIG1vdmVkIHZhcmlhYmxlcy4KLS0t CiBzcmMvaW5jbHVkZS9wb3N0bWFzdGVyL3N5c2xvZ2dlci5oIHwgIDIgKy0KIHNyYy9pbmNs dWRlL3N0b3JhZ2UvcG1zaWduYWwuaCAgICAgfCAgMiArLQogc3JjL2luY2x1ZGUvc3RvcmFn ZS9wcm9jLmggICAgICAgICB8ICA0ICsrLS0KIHNyYy9pbmNsdWRlL3N0b3JhZ2UvcHJvY3Np Z25hbC5oICAgfCAgMiArLQogc3JjL2luY2x1ZGUvdXRpbHMvZ3VjLmggICAgICAgICAgICB8 IDEwICsrKysrLS0tLS0KIDUgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTAg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvcG9zdG1hc3Rlci9zeXNs b2dnZXIuaCBiL3NyYy9pbmNsdWRlL3Bvc3RtYXN0ZXIvc3lzbG9nZ2VyLmgKaW5kZXggYjVm YzIzOWJhOWMuLjk0ZWEyNjNmMmJmIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9wb3N0bWFz dGVyL3N5c2xvZ2dlci5oCisrKyBiL3NyYy9pbmNsdWRlL3Bvc3RtYXN0ZXIvc3lzbG9nZ2Vy LmgKQEAgLTc2LDcgKzc2LDcgQEAgZXh0ZXJuIFBHRExMSU1QT1JUIGJvb2wgTG9nX3RydW5j YXRlX29uX3JvdGF0aW9uOwogZXh0ZXJuIFBHRExMSU1QT1JUIGludCBMb2dfZmlsZV9tb2Rl OwogCiAjaWZkZWYgRVhFQ19CQUNLRU5ECi1leHRlcm4gcGdfdGltZV90IGZpcnN0X3N5c2xv Z2dlcl9maWxlX3RpbWU7CitleHRlcm4gUEdETExJTVBPUlQgcGdfdGltZV90IGZpcnN0X3N5 c2xvZ2dlcl9maWxlX3RpbWU7CiAjZW5kaWYKIAogI2lmbmRlZiBXSU4zMgpkaWZmIC0tZ2l0 IGEvc3JjL2luY2x1ZGUvc3RvcmFnZS9wbXNpZ25hbC5oIGIvc3JjL2luY2x1ZGUvc3RvcmFn ZS9wbXNpZ25hbC5oCmluZGV4IDBjOWE3ZTMyYThhLi44N2FjOTE4NDhiYyAxMDA2NDQKLS0t IGEvc3JjL2luY2x1ZGUvc3RvcmFnZS9wbXNpZ25hbC5oCisrKyBiL3NyYy9pbmNsdWRlL3N0 b3JhZ2UvcG1zaWduYWwuaApAQCAtNTgsNyArNTgsNyBAQCB0eXBlZGVmIGVudW0KIHR5cGVk ZWYgc3RydWN0IFBNU2lnbmFsRGF0YSBQTVNpZ25hbERhdGE7CiAKICNpZmRlZiBFWEVDX0JB Q0tFTkQKLWV4dGVybiB2b2xhdGlsZSBQTVNpZ25hbERhdGEgKlBNU2lnbmFsU3RhdGU7Citl eHRlcm4gUEdETExJTVBPUlQgdm9sYXRpbGUgUE1TaWduYWxEYXRhICpQTVNpZ25hbFN0YXRl OwogI2VuZGlmCiAKIC8qCmRpZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9zdG9yYWdlL3Byb2Mu aCBiL3NyYy9pbmNsdWRlL3N0b3JhZ2UvcHJvYy5oCmluZGV4IGJiZDg5M2E1NDRlLi5kZWVi MDZjOWUwMSAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvc3RvcmFnZS9wcm9jLmgKKysrIGIv c3JjL2luY2x1ZGUvc3RvcmFnZS9wcm9jLmgKQEAgLTQ1NCw4ICs0NTQsOCBAQCBleHRlcm4g UEdETExJTVBPUlQgaW50IElkbGVTZXNzaW9uVGltZW91dDsKIGV4dGVybiBQR0RMTElNUE9S VCBib29sIGxvZ19sb2NrX3dhaXRzOwogCiAjaWZkZWYgRVhFQ19CQUNLRU5ECi1leHRlcm4g c2xvY2tfdCAqUHJvY1N0cnVjdExvY2s7Ci1leHRlcm4gUEdQUk9DICpBdXhpbGlhcnlQcm9j czsKK2V4dGVybiBQR0RMTElNUE9SVCBzbG9ja190ICpQcm9jU3RydWN0TG9jazsKK2V4dGVy biBQR0RMTElNUE9SVCBQR1BST0MgKkF1eGlsaWFyeVByb2NzOwogI2VuZGlmCiAKIApkaWZm IC0tZ2l0IGEvc3JjL2luY2x1ZGUvc3RvcmFnZS9wcm9jc2lnbmFsLmggYi9zcmMvaW5jbHVk ZS9zdG9yYWdlL3Byb2NzaWduYWwuaAppbmRleCAyNTE2ODY5NDY1ZC4uZjk0YzExYTlhODQg MTAwNjQ0Ci0tLSBhL3NyYy9pbmNsdWRlL3N0b3JhZ2UvcHJvY3NpZ25hbC5oCisrKyBiL3Ny Yy9pbmNsdWRlL3N0b3JhZ2UvcHJvY3NpZ25hbC5oCkBAIC03Nyw3ICs3Nyw3IEBAIGV4dGVy biB2b2lkIHByb2NzaWduYWxfc2lndXNyMV9oYW5kbGVyKFNJR05BTF9BUkdTKTsKIHR5cGVk ZWYgc3RydWN0IFByb2NTaWduYWxIZWFkZXIgUHJvY1NpZ25hbEhlYWRlcjsKIAogI2lmZGVm IEVYRUNfQkFDS0VORAotZXh0ZXJuIFByb2NTaWduYWxIZWFkZXIgKlByb2NTaWduYWw7Citl eHRlcm4gUEdETExJTVBPUlQgUHJvY1NpZ25hbEhlYWRlciAqUHJvY1NpZ25hbDsKICNlbmRp ZgogCiAjZW5kaWYJCQkJCQkJLyogUFJPQ1NJR05BTF9IICovCmRpZmYgLS1naXQgYS9zcmMv aW5jbHVkZS91dGlscy9ndWMuaCBiL3NyYy9pbmNsdWRlL3V0aWxzL2d1Yy5oCmluZGV4IGJh Njg4M2FlOGZjLi4wZjU5ZGU1NDJmMyAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvdXRpbHMv Z3VjLmgKKysrIGIvc3JjL2luY2x1ZGUvdXRpbHMvZ3VjLmgKQEAgLTMxNSwxMSArMzE1LDEx IEBAIGV4dGVybiBQR0RMTElNUE9SVCBib29sIG9wdGltaXplX2JvdW5kZWRfc29ydDsKICAq IHRoYXQgd291bGQgdGhlbiByZXF1aXJlIGluY2x1ZGluZyB0aGUgZGVmaW5pdGlvbiBvZiBz dHJ1Y3QKICAqIGNvbmZpZ19lbnVtX2VudHJ5IGludG8gdGhvc2UgaGVhZGVyIGZpbGVzLikK ICAqLwotZXh0ZXJuIGNvbnN0IHN0cnVjdCBjb25maWdfZW51bV9lbnRyeSBhcmNoaXZlX21v ZGVfb3B0aW9uc1tdOwotZXh0ZXJuIGNvbnN0IHN0cnVjdCBjb25maWdfZW51bV9lbnRyeSBk eW5hbWljX3NoYXJlZF9tZW1vcnlfb3B0aW9uc1tdOwotZXh0ZXJuIGNvbnN0IHN0cnVjdCBj b25maWdfZW51bV9lbnRyeSByZWNvdmVyeV90YXJnZXRfYWN0aW9uX29wdGlvbnNbXTsKLWV4 dGVybiBjb25zdCBzdHJ1Y3QgY29uZmlnX2VudW1fZW50cnkgd2FsX2xldmVsX29wdGlvbnNb XTsKLWV4dGVybiBjb25zdCBzdHJ1Y3QgY29uZmlnX2VudW1fZW50cnkgd2FsX3N5bmNfbWV0 aG9kX29wdGlvbnNbXTsKK2V4dGVybiBQR0RMTElNUE9SVCBjb25zdCBzdHJ1Y3QgY29uZmln X2VudW1fZW50cnkgYXJjaGl2ZV9tb2RlX29wdGlvbnNbXTsKK2V4dGVybiBQR0RMTElNUE9S VCBjb25zdCBzdHJ1Y3QgY29uZmlnX2VudW1fZW50cnkgZHluYW1pY19zaGFyZWRfbWVtb3J5 X29wdGlvbnNbXTsKK2V4dGVybiBQR0RMTElNUE9SVCBjb25zdCBzdHJ1Y3QgY29uZmlnX2Vu dW1fZW50cnkgcmVjb3ZlcnlfdGFyZ2V0X2FjdGlvbl9vcHRpb25zW107CitleHRlcm4gUEdE TExJTVBPUlQgY29uc3Qgc3RydWN0IGNvbmZpZ19lbnVtX2VudHJ5IHdhbF9sZXZlbF9vcHRp b25zW107CitleHRlcm4gUEdETExJTVBPUlQgY29uc3Qgc3RydWN0IGNvbmZpZ19lbnVtX2Vu dHJ5IHdhbF9zeW5jX21ldGhvZF9vcHRpb25zW107CiAKIC8qCiAgKiBGdW5jdGlvbnMgZXhw b3J0ZWQgYnkgZ3VjLmMKLS0gCjIuMzkuMgoK --------------187AJgikZzVIzPy0cHuTyJl7--