Subject: Re: HEAPDEBUGALL is broken
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <645c0646-4218-d4c3-409a-a7003a0c108d@2ndquadrant.com>
 <26609.1587303428@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <e1309adf-a0f3-c5dd-7654-7034418b043e@2ndquadrant.com>
Date: Tue, 21 Apr 2020 20:11:26 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <26609.1587303428@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-04-19 15:37, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> The HEAPDEBUGALL define has been broken since PG12 due to tableam
>> changes.  Should we just remove this?  It doesn't look very useful.
>> It's been around since Postgres95.
>> If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL
>> (which still compiles correctly).  Would we want to keep that?
> 
> +1 for removing both.  There are a lot of such debug "features"
> in the code, and few of them are worth anything IME.

removed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services