Feedback-ID: i131946ab:Fastmail
Message-ID: <e185b889-dc0b-f49a-1260-3e152a69bef8@enterprisedb.com>
Date: Tue, 15 Nov 2022 15:52:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.1
Subject: Re: Check return value of pclose() correctly
Content-Language: en-US
To: Ankit Kumar Pandey <itsankitkp@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <8cd9fb02-bc26-65f1-a809-b1cb360eef73@enterprisedb.com>
 <175ef638-32c7-1a84-590c-6df7497baeea@enterprisedb.com>
 <166740281339.1122.15508017124113465236.pgcf@coridan.postgresql.org>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <166740281339.1122.15508017124113465236.pgcf@coridan.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e185b889-dc0b-f49a-1260-3e152a69bef8%40enterprisedb.com>
Precedence: bulk

On 02.11.22 16:26, Ankit Kumar Pandey wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            tested, passed
> 
> Hi Peter,
> This is a review of the pclose return value check patch:
> 
> Contents & Purpose:
> Purpose of this patch is to properly handle return value of pclose (indirectly, return from ClosePipeStream).
> 
> Initial Run:
> The patch applies cleanly to HEAD. The regression tests all pass
> successfully against the new patch.
> 
> Conclusion:
> At some places pclose return value is handled and this patch adds return value check for remaining values.
> Implementation is in sync with existing handling of pclose.

Committed.  Thanks for the review.