Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmPp3-0000dm-1s for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Sep 2016 18:31:13 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bmPp2-00031f-He for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Sep 2016 18:31:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bmPne-0001Qw-R7 for pgsql-hackers@postgresql.org; Tue, 20 Sep 2016 18:29:46 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bmPnb-0005Bi-2A for pgsql-hackers@postgresql.org; Tue, 20 Sep 2016 18:29:46 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2AFA13B3C7; Tue, 20 Sep 2016 18:29:40 +0000 (UTC) Received: from localhost.localdomain (vpn-53-134.rdu2.redhat.com [10.10.53.134]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8KITc9P024606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 20 Sep 2016 14:29:39 -0400 Subject: Re: pageinspect: Hash index support To: Ashutosh Sharma References: <20160830170633.GA508711@alvherre.pgsql> <0f99b6b0-0e54-0f6e-9502-f8cb6f194c17@redhat.com> <3493caf5-6d50-8915-7612-bd830972f513@redhat.com> Cc: Jeff Janes , Michael Paquier , Alvaro Herrera , PostgreSQL Hackers From: Jesper Pedersen Organization: JBoss, by Red Hat Message-ID: Date: Tue, 20 Sep 2016 14:29:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 20 Sep 2016 18:29:40 +0000 (UTC) X-Pg-Spam-Score: -10.0 (----------) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Hi, On 09/20/2016 01:46 PM, Ashutosh Sharma wrote: > I am getting a fatal error along with some warnings when trying to > apply the v3 patch using "git apply" command. > > [ashu@localhost postgresql]$ git apply > 0001-pageinspect-Hash-index-support_v3.patch > 0001-pageinspect-Hash-index-support_v3.patch:29: trailing whitespace. > brinfuncs.o ginfuncs.o hashfuncs.o $(WIN32RES) > 0001-pageinspect-Hash-index-support_v3.patch:36: trailing whitespace. > DATA = pageinspect--1.6.sql pageinspect--1.5--1.6.sql \ > 0001-pageinspect-Hash-index-support_v3.patch:37: trailing whitespace. > pageinspect--1.4--1.5.sql pageinspect--1.3--1.4.sql \ > 0001-pageinspect-Hash-index-support_v3.patch:38: trailing whitespace. > pageinspect--1.2--1.3.sql pageinspect--1.1--1.2.sql \ > 0001-pageinspect-Hash-index-support_v3.patch:39: trailing whitespace. > pageinspect--1.0--1.1.sql pageinspect--unpackaged--1.0.sql > fatal: git apply: bad git-diff - expected /dev/null on line 46 > Which platform are you on ? The development branch is @ https://github.com/jesperpedersen/postgres/tree/pageinspect_hash > Also, i think the USAGE for hash_metap() is refering to > hash_metap_bytea(). Please correct it. I have just started reviewing > the patch, will keep on posting my comments upon further review. Fixed in v4. Thanks for the review. Best regards, Jesper -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers