Feedback-ID: i0c21471d:Fastmail
MIME-Version: 1.0
Date: Thu, 06 Mar 2025 18:33:06 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Andrew Dunstan" <andrew@dunslane.net>,
 "Alvaro Herrera" <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Message-Id: <e1f48532-fd01-4e8f-9ca7-860fdafd860c@app.fastmail.com>
In-Reply-To: <001f81e3-2be8-46ad-9aee-1a761686712c@dunslane.net>
References: <202502051851.2nvzh3a6ukzc@alvherre.pgsql>
 <313aa202-b5fa-4e3f-95d0-83425575c66d@app.fastmail.com>
 <001f81e3-2be8-46ad-9aee-1a761686712c@dunslane.net>
Subject: Re: log_min_messages per backend type
Content-Type: multipart/alternative;
 boundary=f42d718124d948c49327931105ced0a0
Archived-At: <https://www.postgresql.org/message-id/e1f48532-fd01-4e8f-9ca7-860fdafd860c%40app.fastmail.com>
Precedence: bulk

--f42d718124d948c49327931105ced0a0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Wed, Mar 5, 2025, at 1:40 PM, Andrew Dunstan wrote:
> Just bikeshedding a bit ...
> 
> I'm not mad keen on this design. I think the value should be either a single setting like "WARNING" or a set of type:setting pairs. I agree that "all" is a bad name, but I think "default" would make sense.
> 

One of my main concerns was a clear interface. I think "default" is less
confusing than "all". Your suggestion about single or list is aligned with what
Alvaro suggested. IIUC you are suggesting default:loglevel only if it is part
of the list; the single loglevel shouldn't contain the backend type to keep the
backward compatibility. The advantage of your proposal is that it make it clear
what the fallback log level is. However, someone could be confused asking if
the "default" is a valid backend type and if there is a difference between
WARNING and default:WARNING (both is a fallback for non-specified backend type
elements).


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--f42d718124d948c49327931105ced0a0
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">=0Ap.=
MsoNormal,p.MsoNoSpacing{margin:0}=0Ap.MsoNormal,p.MsoNoSpacing{margin:0=
}</style></head><body><div>On Wed, Mar 5, 2025, at 1:40 PM, Andrew Dunst=
an wrote:<br></div><blockquote type=3D"cite" id=3D"qt" style=3D""><p>Jus=
t bikeshedding a bit ...<br></p><p>I'm not mad keen on this design. I th=
ink the value should be=0A      either a single setting like "WARNING" o=
r a set of type:setting=0A      pairs. I agree that "all" is a bad name,=
 but I think "default"=0A      would make sense.<br></p></blockquote><di=
v><br></div><div>One of my main concerns was a clear interface. I think =
"default" is less<br></div><div>confusing than "all". Your suggestion ab=
out single or list is aligned with what<br style=3D"max-width:100%;heigh=
t:auto;"></div><div>Alvaro suggested. IIUC you are suggesting default:lo=
glevel only if it is part<br style=3D"max-width:100%;height:auto;"></div=
><div>of the list; the single loglevel shouldn't contain the backend typ=
e to keep the<br style=3D"max-width:100%;height:auto;"></div><div>backwa=
rd compatibility. The advantage of your proposal is that it make it clea=
r<br style=3D"max-width:100%;height:auto;"></div><div>what the fallback =
log level is. However, someone could be confused asking if<br style=3D"m=
ax-width:100%;height:auto;"></div><div>the "default" is a valid backend =
type and if there is a difference between<br style=3D"max-width:100%;hei=
ght:auto;"></div><div>WARNING and default:WARNING (both is a fallback fo=
r non-specified backend type<br style=3D"max-width:100%;height:auto;"></=
div><div>elements).<br></div><div><br style=3D"max-width:100%;height:aut=
o;"></div><div><br></div><div id=3D"sig112409080"><div class=3D"signatur=
e">--<br></div><div class=3D"signature">Euler Taveira<br></div><div clas=
s=3D"signature">EDB&nbsp;&nbsp; <a href=3D"https://www.enterprisedb.com/=
">https://www.enterprisedb.com/</a><br></div></div><div><br></div></body=
></html>
--f42d718124d948c49327931105ced0a0--