public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Andrew Dunstan <[email protected]>
To: Tom Lane <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: pgindent vs. pgperltidy command-line arguments
Date: Wed, 21 Jun 2023 11:09:02 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On 20.06.23 17:38, Andrew Dunstan wrote:
>>> +1, although I wonder if we shouldn't follow pgindent's new lead
>>> and require some argument(s).
>>
>> That makes sense to me.  Here is a small update with this behavior 
>> change and associated documentation update.
> 
> I'm intending to add some of the new pgindent features to pgperltidy. 
> Preparatory to that here's a rewrite of pgperltidy in perl - no new 
> features yet but it does remove the hardcoded path, and requires you to 
> pass in one or more files / directories as arguments.

Are you planning to touch pgperlcritic and pgperlsyncheck as well?  If 
not, part of my patch would still be useful.  Maybe I should commit my 
posted patch for PG16, to keep consistency with pgindent, and then your 
work would presumably be considered for PG17.

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgindent vs. pgperltidy command-line arguments
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox