Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iCQi8-0003lZ-Q0 for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Sep 2019 15:57:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iCQi7-0006II-LB for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Sep 2019 15:57:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iCQi7-0006IB-9x for pgsql-hackers@lists.postgresql.org; Mon, 23 Sep 2019 15:57:11 +0000 Received: from cyclops.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1iCQi4-0003XZ-6J for pgsql-hackers@lists.postgresql.org; Mon, 23 Sep 2019 15:57:10 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 7676021C49BC; Mon, 23 Sep 2019 18:57:05 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from mail.postgrespro.ru (cyclops.l.postgrespro.ru [192.168.27.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 4C44D21C49B7; Mon, 23 Sep 2019 18:57:05 +0300 (MSK) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 23 Sep 2019 18:57:04 +0300 From: Marina Polyakova To: Alvaro Herrera Cc: pgsql-hackers@lists.postgresql.org, Victor Wagner Subject: Re: pg_upgrade check fails on Solaris 10 Organization: Postgres Professional In-Reply-To: <20190918143600.GA4211@alvherre.pgsql> References: <20190918143600.GA4211@alvherre.pgsql> Message-ID: X-Sender: m.polyakova@postgrespro.ru User-Agent: Roundcube Webmail/1.3.8 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-09-18 17:36, Alvaro Herrera wrote: > On 2019-Sep-17, Marina Polyakova wrote: > >> Hello, hackers! >> >> We got an error for pg_upgrade check on the branch REL_11_STABLE >> (commit >> 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC >> the >> argument to the sed command is not enclosed in quotation marks (see >> [1]): > > Hmm, I'm surprised it has taken this long to detect the problem. Looking at the members of buildfarm [1] castoroides and protosciurus - IIUC they do not check pg_upgrade. And I was that lucky one who have run the branch with the latest commits at our buildfarm... >> Attached diff.patch fixes the problem. > > I have pushed it to all branches that have src/bin/pg_upgrade (namely, > 9.5 onwards), thanks. I hope this won't make the msys/mingw machines > angry ;-) Thank you! I ran pg_upgrade tests for MSYS, everything is fine. The branch REL9_4_STABLE (commit 8a17afe84be6fefe76d0d2f4d26c5ee075e64487) has the same issue - according to the release table [2] it is still supported, isn't it?... [1] https://buildfarm.postgresql.org/cgi-bin/show_members.pl [2] https://www.postgresql.org/support/versioning/ -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company