Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vvzIi-00E4Rh-0m for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Feb 2026 14:58:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vvzIg-0048XT-0L for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Feb 2026 14:58:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vvzIf-0048XD-1h for pgsql-hackers@lists.postgresql.org; Fri, 27 Feb 2026 14:58:41 +0000 Received: from mail-yw1-x112d.google.com ([2607:f8b0:4864:20::112d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vvzIb-00000001aOD-39TR for pgsql-hackers@lists.postgresql.org; Fri, 27 Feb 2026 14:58:41 +0000 Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-79881805788so15183667b3.0 for ; Fri, 27 Feb 2026 06:58:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joeconway.com; s=google; t=1772204317; x=1772809117; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NH/HE/6Uh+uB97B2LvuDDLlhyLQH1LQWts5oYdp8IeI=; b=Sp7DjDh85/hpOlHmxf8FIktYDTW5Zr31Zal5vhInpp8wnXNkQugQR27KHkIPnpH9ws 4XB9iJt3UyUxe7SJZUBOkJdkDv8t/fk6DMMjBqOju6NkZtXrdFp6ULKaKqNfbqdaD25K GhnLtLPEapztWjXUmJheLhDiP2CAJUCsgm0VBrmGeNQfEpSzAAvJ51TTR0hc6ZamRaHC zYly7ooGblweIcoxQrYjV2Tl7Iw7tFXXXq+C5PZ8xuFfGYeKLuw95oya4iFMefrNPEXL OMfcweFVDRhW2m/f+lETXcQ4PZ9ol+doz9ap8pQVIyZEgWsvh1rEYh9MM78uCePqiUjH Lt3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772204317; x=1772809117; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NH/HE/6Uh+uB97B2LvuDDLlhyLQH1LQWts5oYdp8IeI=; b=CAvrKm4LcNeIpbXysApx54JJFHH7ikJUNcDV0o6s/gebEaok1Xg45PNEbnJmO+yoZO sdPWEDd30kr4XW5tdjhqX6gz6nUXpAxfCltoNMVjyT6KxlPARlOIVHVNApq/kBFUojmJ uwqzFEyfkkKxhO+Rm1pSShXr3Eo2lhskMPGQ0g8ZJY2bMBvnpd4jvVGrFr9gBeISqSmc 3r7BCFI+sUWnrzAkhmXeYYt0+sIBGJY+vKVLk1f0xbGDZ+tzpE1Li8+aBy3wmpPO8uc7 0T1UUXIz2ygIFzdNPymwgP/W0IOan846K59+b1kgpyreLn9K/58E5w5okyVzv/QDNZ1X zb6Q== X-Gm-Message-State: AOJu0YwfQiGF5IQG92PCtcPkbMkSkpuE6+4Y74gEYFwU0UHFcBvxjmB8 Y0FIl9We2dBpGYX49VkNYkK0vxuf1nIrSsHhdNkm+eei3edeWlqA/B246Div0fD4gzM= X-Gm-Gg: ATEYQzz8wI9HacTNUioWHf0TEEoVvWk58vIbSiAMNob/rJaeQUedVUl/i7fdLFhioBZ 0xf/aLg4tKrioN/R/+CETOixAJmmSxynwB8FGH2MCgz0stH4DKQiH6V/q6AA/NpO6J2Vp2pGii+ yhkKtzyYAUKZTH0193ZTyBKlF8l9OD61ead52DSaQvrOTTAs3nHuINsgPKQ9Eo7jZku1zDdJB+F mqH9kxoeKKZggncvvnoI4LIIuYEzN+jj7d41ZzGF2jlXgMDfSn5DRgWzV+D811TqZ24S4vf6Wbw xpjyA7q0nbgolaQ6DXlwlgrDfdSVxNqOWvu95AFY8slMV/E56t9eFrP9Df70Bsb2ebIftQ3gKFX ks16fXpW2AFhj3NfkwqoqU9/Y83myxcX4trP0g1hgvM4Xu6dQPSWFgW/rFJPv4Qz4gtfp0KSTmY CjQkW3qfU7P3xuxxJyw/P3TKuK X-Received: by 2002:a05:690c:9688:b0:798:806:2c7c with SMTP id 00721157ae682-798850ed2damr31934057b3.0.1772204316743; Fri, 27 Feb 2026 06:58:36 -0800 (PST) Received: from [192.168.4.42] ([46.110.138.68]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876c58f31sm22156807b3.40.2026.02.27.06.58.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 06:58:35 -0800 (PST) Message-ID: Date: Fri, 27 Feb 2026 09:58:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version() To: Chao Li , Bertrand Drouvot Cc: pgsql-hackers@lists.postgresql.org, Jeff Davis References: <2E8E63C9-A2F6-4723-A937-B9F6CB34C88A@gmail.com> Content-Language: en-US From: Joe Conway In-Reply-To: <2E8E63C9-A2F6-4723-A937-B9F6CB34C88A@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2/27/26 01:04, Chao Li wrote: > What I'm interested in is the broader policy: when reviewing > patches, if we encounter a foo() declaration, should we consistently > request a change to foo(void)? If yes, the standard should be > documented somewhere. Perhaps here? https://wiki.postgresql.org/wiki/Committing_checklist -- Joe Conway PostgreSQL Contributors Team Amazon Web Services: https://aws.amazon.com