Subject: Re: proposal: possibility to read dumped table's name from file
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Pavel Stehule <pavel.stehule@gmail.com>,
 Justin Pryzby <pryzby@telsasoft.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 Dean Rasheed <dean.a.rasheed@gmail.com>, Stephen Frost <sfrost@snowman.net>,
 Surafel Temesgen <surafel3000@gmail.com>,
 Alvaro Herrera <alvherre@2ndquadrant.com>, vignesh C <vignesh21@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <20201110200904.GU16415@tamriel.snowman.net>
 <CAFj8pRDTmY0A1RzrS9csuzsq7+PHqcAui09ZGO_48vOBOfZt1Q@mail.gmail.com>
 <20201117215321.GF24784@telsasoft.com>
 <CAFj8pRBuEOCTGR8VwhQi3_dNg6v=g5zBB4kmACRsnAFiWJKWVA@mail.gmail.com>
 <CAFj8pRBoZ1yY7Q_UBCiRFicKvtpxdzkuyus701A4wKe9z9d-9Q@mail.gmail.com>
 <CAEZATCVKMG7+b+_5tNwrNZ-aNDBy3=FMRNea2bO9O4qGcEvSTg@mail.gmail.com>
 <CAFj8pRDKQiiuHuzRwj6aca=ZkKpu7UdqBzgLmPmg_=BYYzD9zw@mail.gmail.com>
 <502641.1606334432@sss.pgh.pa.us>
 <CAFj8pRCtfaoD0QOAxrcQCqvJBbTr4ryhBkk2MJQhUJK-dLjdPw@mail.gmail.com>
 <20201128234945.GM24052@telsasoft.com>
 <CAFj8pRCrbDPAWyHjwZauEX78jyGBowOoiaWySA0ibRYoWzZTMw@mail.gmail.com>
 <CAFj8pRDcEjL-pEWmZj-3p5W6Xg29xbd6D2hdyPxZ5Znw0OXqJA@mail.gmail.com>
 <CAFj8pRBmOm9yxvOLbvYfZvAdVJ4jc084=-c3MG5_kZDk0NL5UA@mail.gmail.com>
 <CAFj8pRBkHSSq4epfVBfkabBtf_ZZMcRb8uC-YgxdbOzwCnhKug@mail.gmail.com>
 <cb545d78-2dae-8d27-f062-822a07ca56cf@enterprisedb.com>
 <C3B39E37-9BF6-4E0C-83F1-75ED515586AA@yesql.se>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
Message-ID: <e239d50e-a89e-4d4c-5464-cf6c3b71dcce@enterprisedb.com>
Date: Tue, 13 Jul 2021 00:47:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <C3B39E37-9BF6-4E0C-83F1-75ED515586AA@yesql.se>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e239d50e-a89e-4d4c-5464-cf6c3b71dcce%40enterprisedb.com>
Precedence: bulk

On 7/13/21 12:08 AM, Daniel Gustafsson wrote:
>> On 10 Jul 2021, at 17:47, Tomas Vondra <tomas.vondra@enterprisedb.com> wrote:
> 
>> So if it was up to me, I'd go back to the original format or something close it. So something like this:
>>
>> [+-] OBJECT_TYPE_PATTERN OBJECT_NAME_PATTERN
> 
> That still leaves the parsing with quoting and escaping that needs to be done
> less trivial and more bespoke than what meets the eye, no?
> 

Yes, it'd require proper escaping/quoting of the fields/identifiers etc.

> As mentioned upthread, I'm still hesitant to add a file format which deosn't
> have any version information of sorts for distinguishing it from when the
> inevitable "now wouldn't it be nice if we could do this too" patch which we all
> know will come.  The amount of selectivity switches we have for pg_dump is an
> indication about just how much control users like, this will no doubt be
> subject to the same.
> 

I'm not going to fight against some sort of versioning, but I think 
keeping the scope as narrow as possible would make it unnecessary. That 
is, let's stick to the original goal to allow passing filtering rules 
that would not fit on the command-line, and maybe let's make it a bit 
more flexible to support other object types etc.

IMHO the filtering rules are simple enough to not really need elaborate 
versioning, and if a more advanced rule is proposed in the future it can 
be supported in the existing format (extra field, ...).

Of course, maybe my imagination is not wild enough.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company