Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wD4wX-002a6U-0J for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Apr 2026 18:26:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wD4wW-001N8a-0j for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Apr 2026 18:26:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wD4wV-001N8R-2z for pgsql-hackers@lists.postgresql.org; Wed, 15 Apr 2026 18:26:27 +0000 Received: from fout-b3-smtp.messagingengine.com ([202.12.124.146]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wD4wT-00000001BoG-3XZv for pgsql-hackers@lists.postgresql.org; Wed, 15 Apr 2026 18:26:27 +0000 Received: from phl-compute-07.internal (phl-compute-07.internal [10.202.2.47]) by mailfout.stl.internal (Postfix) with ESMTP id D21901D001ED; Wed, 15 Apr 2026 14:26:24 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-07.internal (MEProxy); Wed, 15 Apr 2026 14:26:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1776277584; x=1776363984; bh=ABuQ/7nDnRTBM+MUMtnwK/XRzDkS2B+x nXyplxAp230=; b=Qxb8w0wc7VW9Zmr4150HaGBrro0I7HVHA5ndzHFK1U0+kUAx cqNGMR3CfgYKI73/IH9H4JrwI983+1aV9cYIAFJKvntBJ6rYTrueP6MHTQvZjO3Z /E18JOku4HVScpFGIdUn9DYimJ63vZ5IL+GPQe0aKo/mAcOE2hbK7Zip9FTYacOT zhk2NdT/To+HKFF+0poeSMikRCFko6dYiVU4IlWowk3Uc+STPEsFPHh0B8FPA/0r YiLUS1t8joTAH4CQFAWGekS9GSr7qoJ+9Xqr38ML8R3pEX2SminssArZAenvYO5d nebDtgF/waKnsd1mUuGmwGwQfqNCROLjpP7wHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1776277584; x= 1776363984; bh=ABuQ/7nDnRTBM+MUMtnwK/XRzDkS2B+xnXyplxAp230=; b=U zIHSIAsGbzri+y4R+amqu3SrIVxGPsvEWFVPdyIHnQqikubnu9GMQ+PLRTo5R01c e2DMVNvF7JyRWG8w4aV6bpbedIPxov0+4KTGpRDdI3WqCqj8Nkuj2I+MXv6ooQLo vRSnZRwehoL2EDDOPHbw1pw03b7AFLxRlfTLqLz31OpR9pjz6smENpxtkZL5nBKy srLhPmT5FlPSYHnWxF3oMrvUyeWYW3+7foBlsP0yImYzXB2XIU3k2tQnckOZ3SCr WzZxfkXTDiQkAH7aIzEpGwwyLmjGxnybWvA9FNWm4+v8rCkESY0tda/+7vrUHFoS M46gdRQ6fybwRBOXaqmMQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdeggeekudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefkffggfgfuvfevfhfhjggtgfesthekredttddvjeenucfhrhhomheprfgvthgvrhcu gfhishgvnhhtrhgruhhtuceophgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgqeenuc ggtffrrghtthgvrhhnpeejhfevhedttefgfffhhfeffefggffhffelgfeiueeukeehvdeh vdefheffvdefueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehpvghtvghrsegvihhsvghnthhrrghuthdrohhrghdpnhgspghrtghpthhtohep gedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshhmihhthhhpsgdvvdehtdesgh hmrghilhdrtghomhdprhgtphhtthhopeifgihppgejvdekseduieefrdgtohhmpdhrtghp thhtoheplhhirdgvvhgrnhdrtghhrghosehgmhgrihhlrdgtohhmpdhrtghpthhtohepph hgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Apr 2026 14:26:23 -0400 (EDT) Message-ID: Date: Wed, 15 Apr 2026 20:26:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Add missing period to DETAIL messages To: Peter Smith , Xiaopeng Wang Cc: Chao Li , PostgreSQL Hackers References: <74359511-9F84-481E-B133-D2F68775D1CE@gmail.com> Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 15.04.26 09:41, Peter Smith wrote: > On Wed, Apr 15, 2026 at 3:48 PM Xiaopeng Wang wrote: >> > ... >> >> Looks good to me. >> >> A small comment is that, the commit message claims only “add missing period to DETAIL messages”, but apparently the patch also changes capitalization in many places, so the commit message should be updated. >> > > Fair point. Thanks for your review! > > PSA v4 which has an improved commit message. Most of these look good, but I don't think this is an improvement: -DETAIL: syntax error at end of input +DETAIL: syntax error at end of input. The guidelines say that the detail message should be a sentence. But this is not a sentence. Just adding a period doesn't make it a sentence. IMO, having a period at the end of a thing that is not a sentence is worse than not having it be a sentence. The latter just violates our quality standards, the former is confusing for a user who sees that particular output.