Date: Tue, 26 Sep 2023 16:50:20 -0500 (CDT)
From: "Karl O. Pinc" <kop@karlpinc.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
	'jian he' <jian.universality@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Message-ID: <e2a148d9-3f2c-4a86-b493-35c41ed75e93@karlpinc.com>
In-Reply-To: <434567.1695751283@sss.pgh.pa.us>
References: <TYAPR01MB586631D0961BF9C44893FAB1F523A@TYAPR01MB5866.jpnprd01.prod.outlook.com> <CACJufxFkp8c0ap6YhyXRpVkjsB8pwZjWH9Hqc1tVF0aNWFRzFA@mail.gmail.com> <TYAPR01MB58662BC412E1290FC3348973F525A@TYAPR01MB5866.jpnprd01.prod.outlook.com> <CACJufxHn1=Phy6E=1PDO0AMXhP1S+XrP5Cioa_rynYpO7gC+=g@mail.gmail.com> <TYAPR01MB5866CD2A823B196FBE7F19B9F52EA@TYAPR01MB5866.jpnprd01.prod.outlook.com> <20230926010328.2c556046@slate.karlpinc.com> <TYAPR01MB586607D53C42E59DBB00FD9AF5C3A@TYAPR01MB5866.jpnprd01.prod.outlook.com> <20230926124553.6884c912@slate.karlpinc.com> <434567.1695751283@sss.pgh.pa.us>
Subject: Re: [PGdocs] fix description for handling pf non-ASCII characters
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/e2a148d9-3f2c-4a86-b493-35c41ed75e93%40karlpinc.com>
Precedence: bulk

Sep 26, 2023 1:10:55 PM Tom Lane <tgl@sss.pgh.pa.us>:

> "Karl O. Pinc" <kop@karlpinc.com> writes:
>> For the last hunk you'd change around "anything".=C2=A0 Write:
>> "... it will be truncated to less than NAMEDATALEN characters and
>> the bytes of the string which are not printable ASCII characters ...".
>
>> Notice that I have also changed "that" to "which" just above.=C2=A0
>> I _think_ this is better English.
>
> No, I'm pretty sure you're mistaken.=C2=A0 It's been a long time since
> high school English, but the way I think this works is that "that"
> introduces a restrictive clause, which narrows the scope of what
> you are saying.=C2=A0 That is, you say "that" when you want to talk
> about only the bytes of the string that aren't ASCII.=C2=A0 But "which"
> introduces a non-restrictive clause that adds information or
> commentary.=C2=A0 If you say "bytes of the string which are not ASCII",
> you are effectively making a side assertion that no byte of the
> string is ASCII.=C2=A0 Which is not the meaning you want here.

Makes sense to me.=C2=A0 "That" it is.

Thanks for the help. I never would have figured that out.