Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwo1q-0001lp-VR for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Dec 2021 16:18:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mwo1p-0003TQ-AV for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Dec 2021 16:18:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwo1o-0003TG-N1 for pgsql-hackers@lists.postgresql.org; Mon, 13 Dec 2021 16:18:17 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mwo1k-0000ST-97 for pgsql-hackers@lists.postgresql.org; Mon, 13 Dec 2021 16:18:16 +0000 Received: by mail-ed1-x52b.google.com with SMTP id o20so54268174eds.10 for ; Mon, 13 Dec 2021 08:18:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=+Fkn/MYogKlAwSzgzkqD+PT7R3XFQcfvJMxiHwwZY1A=; b=EzUsUbP43a+oyr4K4BQUkBJgsMi/WntCh4/P6dDE4V47Vjzsc+Oq3cO3PQsf0kB8ZB lA/S/gTFvmESCE7TJ02kdm86KhnjwnEV/ufU457GAJGAr6BBKEuVc+Z3o82U+3fNiAWD Tg4n/Q/nZTuqfd/A3H5ut7GTkeaE11m8/TaUAlQ1vMm4hXPfMBKyfYgJhJxibkQtR4fg NgEjdOf8XYJo2XQPkmzFWPmrm2u5qrA3Qsc3XVAOQhxIYW3mZQGT0ijvBw3zkwRpxdKo nC4nNrIg6d+SPUXg2ibG+IvTvcBSuSx8NNWR7AFdgsWomIM5bu2FDs7V+WBo0lYjUwje kCng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=+Fkn/MYogKlAwSzgzkqD+PT7R3XFQcfvJMxiHwwZY1A=; b=kZNsGeamhAYABP4qeuvVpdc8quob+geHXZCcfApXPuepwbyszR/HCM9ay/NrnVkWQR TPrSJQ2J/sjjMh7SbYZDykL9rO2EhxOEofDgMZowZ7TRq21hENtDL77U9iHcqS2rcNbN KkU1hiuEcLi1yI5Ry8xf0JlaPkvlNEGuLEU3fBnhwPJWZgstmhFnVaSiUD3eVSO2VhG2 qyOxIF2ZWnWXdPGBNY15MAWGPODod51Wtpp4ELxeDObsUcxG4YtUhxFFc/wNKQGTwWiK GPJxemPprFuWNW9y+H9TwdohX212dY/7aJtl+/xIaPFlWVluRmCO9m5BK1y7QUthmeUY LwKQ== X-Gm-Message-State: AOAM533x1JK2UjS3CGpBQDNVs15DGmy31BtRhxfjY2j5IelMCpfEhWMY X7cINhE+LKFGHJJ41NgvfAHRbWWK/LgRRgAnOckC01kk+xAnDLmpBLoDtlctNndO6NN+nW/iMF/ klufpZoWIO7RF31fJRyVrR68Ael2V1bjvfAVcYehCPwQywe4Bswy8/TsAhucYjLsFXwc6+fIcjW /4TTolPiQwuR8c0AsCS6xCluUybS1ipTbzKihZKWd8VruLTmOvaagNFH3XL8Bt X-Google-Smtp-Source: ABdhPJz8WjVtDfjp/x3PmljUqKVYakzVxRI/WRS40wIsAQgzxSKtMoNf0iI8IWhaR1ZdqvjPi3XV0Q== X-Received: by 2002:a17:906:4f17:: with SMTP id t23mr24819800eju.112.1639412290760; Mon, 13 Dec 2021 08:18:10 -0800 (PST) Received: from [10.137.0.18] (ip-86-49-251-241.net.upcbroadband.cz. [86.49.251.241]) by smtp.gmail.com with ESMTPSA id l18sm6320964ejo.114.2021.12.13.08.18.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Dec 2021 08:18:10 -0800 (PST) Message-ID: Date: Mon, 13 Dec 2021 17:18:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: daitch_mokotoff module Content-Language: en-US To: Andrew Dunstan , Dag Lem , PostgreSQL Hackers References: <0cac2d60-5b85-59c6-1ac1-77092b8688b7@enterprisedb.com> <233e19c9-6819-ca0f-5314-f5f9285ac874@dunslane.net> From: Tomas Vondra In-Reply-To: <233e19c9-6819-ca0f-5314-f5f9285ac874@dunslane.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 12/13/21 16:05, Andrew Dunstan wrote: > > On 12/13/21 09:26, Tomas Vondra wrote: >> On 12/13/21 14:38, Dag Lem wrote: >>> Please find attached an updated patch, with the following fixes: >>> >>> * Replaced remaining malloc/free with palloc/pfree. >>> * Made "make check" pass. >>> * Updated notes on other implementations. >>> >> >> Thanks, looks interesting. A couple generic comments, based on a quick >> code review. >> >> 1) Can the extension be marked as trusted, just like fuzzystrmatch? >> >> 2) The docs really need an explanation of what the extension is for, >> not just a link to fuzzystrmatch. Also, a couple examples would be >> helpful, I guess - similarly to fuzzystrmatch. The last line in the >> docs is annoyingly long. > > > It's not clear to me why we need a new module for this. Wouldn't it be > better just to add the new function to fuzzystrmatch? > Yeah, that's a valid point. I think we're quite conservative about adding more contrib modules, and adding a function to an existing one works around a lot of that. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company