Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seSon-007TAL-4w for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Aug 2024 05:14:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1seSol-00EeUz-Sa for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Aug 2024 05:14:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seSol-00EeUq-1c for pgsql-hackers@lists.postgresql.org; Thu, 15 Aug 2024 05:14:35 +0000 Received: from fhigh8-smtp.messagingengine.com ([103.168.172.159]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seSoi-004vgq-DG for pgsql-hackers@postgresql.org; Thu, 15 Aug 2024 05:14:34 +0000 Received: from phl-compute-03.internal (phl-compute-03.nyi.internal [10.202.2.43]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 3B6BA1151C71; Thu, 15 Aug 2024 01:14:30 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Thu, 15 Aug 2024 01:14:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1723698870; x=1723785270; bh=vP1nkdqCs6UtQn/B/OBY8jTHFQoZ4nXc AKFtcrD4FYc=; b=MAzf2QD94hw8XOhPcBCZp9Q99aGBANjTbgltipDTbbPeEE2G qlo7yUjU1p3w/ifldBJsPRpj/uM+8UoiKM+cdbI76GMNkz/IZhHaIgF7pVZ7zgQv EAPa8loow7XzYZSPzE1EwIpnqEzFin16zALtvsXVfUXfuSXgcKZ3KRDLREzxromU w9UPWFERK1SmErn4kwhD/qV4o5SZDXMDOFeOG7wGzeTh3wEzoyoSyOYZcyZUL3xp 4Zm0E+vmpGtgb+8jHoqcS97IB2SbsUvmgkqWvzc9nS3aMxBLBRCOdtv46Jje0Xsd WNQH9zPSfdrq9KDiy6jXZnYMLvcEUMwI57YGJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1723698870; x= 1723785270; bh=vP1nkdqCs6UtQn/B/OBY8jTHFQoZ4nXcAKFtcrD4FYc=; b=k WujQc6hE2mnlEtCK2f2IrDYfI6Mfm+Ql2H5IGFwX6flvXb+oP1v8Omn14PVEOUZI RzZZXsXnzLDMrWA/OCZp6+dvUfJFeyS627IjB+j2zgAu2zY2yIcPMZVdzV7Npeti PX3RCJuwRfLbka3zbrj0MEGyhmfj/7ijn759Mv0gN2xegbaW6r9PN/fA84hvQlfE ak3szfPLkMCJ1vbwyCY1h2v3nlEWZ/m+PqwNvTP2QeExr9rZ1Tq9FQlPqxeolN5M z3A/T3YF5pS9CudCDOgPzMAtSAn5IV0DvmOCDTH+vIk5uk3lIGAZfuZwIHbmSCF0 xV/1L8OrAGxprw2fqhibw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddthedgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvg hnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnhepgfejtdfhkeeftdeugfeileeh teeljeeghfeuledthfeutedvffdukeefjefhgeehnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdho rhhgpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhope gurghnihgvlheshigvshhqlhdrshgvpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghr shesphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Aug 2024 01:14:29 -0400 (EDT) Message-ID: Date: Thu, 15 Aug 2024 07:14:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Variable renaming in dbcommands.c To: Daniel Gustafsson Cc: PostgreSQL Hackers References: <27317B09-4813-4D36-B704-57BDE2786CA9@yesql.se> Content-Language: en-US From: Peter Eisentraut In-Reply-To: <27317B09-4813-4D36-B704-57BDE2786CA9@yesql.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 09.08.24 09:43, Daniel Gustafsson wrote: >> On 9 Aug 2024, at 09:21, Peter Eisentraut wrote: > >> In dbcommands.c function createdb(), there are several sets of very similar local variable names, such as "downer" and "dbowner", which is very confusing and error-prone. The first set are the DefElem nodes from the parser, the second set are the local variables with the values extracted from them. This patch renames the former to "ownerEl" and so on, similar to collationcmds.c and typecmds.c, to improve clarity. > > No objections, patch LGTM. committed