Message-ID: <e2d94c75-a3c1-bc06-f335-73c7225fe5ec@gmail.com>
Date: Mon, 27 Mar 2023 07:45:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Subject: Re: Generate pg_stat_get_xact*() functions with Macros
To: Michael Paquier <michael@paquier.xyz>
Cc: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
 Andres Freund <andres@anarazel.de>,
 Michael Paquier <michael.paquier@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <20230111225907.6el6c5j3hukizqxc@awork3.anarazel.de>
 <e6191040-40c4-6849-7b5d-bf3c227f1755@gmail.com>
 <20230112182434.ejffbun4plv2g37k@awork3.anarazel.de>
 <83f7982d-272a-b064-8a0f-8853354edf10@gmail.com>
 <20230113183746.zyncqr2zz3gk6yh6@awork3.anarazel.de>
 <CAM-w4HNq0SmbDa1jCtbmtCzWrx6G7qAGxsjzcOdEyceGOAdJmA@mail.gmail.com>
 <11744b0e-5f7f-aba8-7d9c-2ff0a0c6e2b2@gmail.com>
 <ZBzpDwOMf1ia+M9l@paquier.xyz>
 <631e3084-c5d9-8463-7540-fcff4674caa5@gmail.com>
 <ZB5hipxlAfZoILgZ@paquier.xyz> <ZCDvYgd8OthCttam@paquier.xyz>
Content-Language: en-US
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZCDvYgd8OthCttam@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/e2d94c75-a3c1-bc06-f335-73c7225fe5ec%40gmail.com>
Precedence: bulk

Hi,

On 3/27/23 3:20 AM, Michael Paquier wrote:
> On Sat, Mar 25, 2023 at 11:50:50AM +0900, Michael Paquier wrote:
>> On Fri, Mar 24, 2023 at 06:58:30AM +0100, Drouvot, Bertrand wrote:
>>> - Does not include the refactoring for
>>> pg_stat_get_xact_function_total_time(),
>>> pg_stat_get_xact_function_self_time(),
>>> pg_stat_get_function_total_time() and
>>> pg_stat_get_function_self_time(). I think they can be done in a
>>> dedicated commit once we agree on the renaming for
>>> PG_STAT_GET_DBENTRY_FLOAT8 (see Andres's comment up-thread) so that
>>> the new macros can match the future agreement.
> 
> Thanks for the reminder.  I have completely missed that this is
> mentioned in [1], and that it is all about 8018ffb.  The suggestion to
> prefix the macro names with a "_MS" to outline the conversion sounds
> like a good one seen from here.  So please find attached a patch to do
> this adjustment, completed with a similar switch for the two counters
> of the function entries.
> 

Thanks! LGTM, but what about also taking care of pg_stat_get_xact_function_total_time()
and pg_stat_get_xact_function_self_time() while at it?

>>> - Does include the refactoring of the new
>>> - pg_stat_get_xact_tuples_newpage_updated() function (added in
>>> - ae4fdde135)
>>
>> Fine by me.  One step is better than no steps, and this helps:
>>   1 file changed, 29 insertions(+), 97 deletions(-)
>>
>> I'll go apply that if there are no objections.
> 
> Just did this part to shave a bit more code.

Thanks!

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com