public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ivan Kush <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: pg_stat_statements: improve loading and saving routines for the dump file
Date: Tue, 21 Jan 2025 18:46:41 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

What does this patch give on aglobal scale? Does it save much memory or 
increase performance? How many times?

On 1/21/25 13:51, [email protected] wrote:
>> // Mutex should be last field, as this field isn't copied to dump file
> Updated.
>
>> 2) You didn't take into account the upgrade. Saved in Postgres with 
>> this byte and try to load in version without this byte.
> The PGSS_DUMP_FILE format is defined by PGSS_FILE_HEADER magic number 
> (the first four bytes in the dump file). Once they does not coinside 
> (when the file is being read) the statistics are not loaded from the 
> dump file and set to zero and the irrelevant dump file is skipped. 
> This is the actual behaviour implemented in the code.
>
> Respectfully,
>
> Mikhail Litsarev,
> Postgres Professional: https://postgrespro.com

-- 
Best wishes,
Ivan Kush
Tantor Labs LLC

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pg_stat_statements: improve loading and saving routines for the dump file
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox