Message-ID: <e318fee2-ab72-9d71-6b8b-c99753f4cecc@gmail.com>
Date: Mon, 10 Jul 2023 07:52:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: Autogenerate some wait events code and documentation
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <0b3cdac7-f078-61a6-76e0-99db7aae78ce@gmail.com>
 <ZKTN//NfDeP1egLW@paquier.xyz>
 <20230705215939.ulnfbr4zavb2x7ri@awork3.anarazel.de>
 <ZKYMfGRK1PIlGiBB@paquier.xyz>
 <20230707011943.qxbj3vj2iwsfgqvq@awork3.anarazel.de>
 <ZKeZVPEBkBxYs1FY@paquier.xyz> <ZKo4b1bDI5+FoTex@paquier.xyz>
 <1f74adab-5ed8-450a-853a-f0b4bfe0e751@gmail.com>
 <ZKpjawSAHIjYV2+Q@paquier.xyz>
 <9682e829-4120-a3d5-4834-d909ad4b49d8@gmail.com>
 <ZKuVKPB+rwYH5cuw@paquier.xyz>
Content-Language: en-US
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZKuVKPB+rwYH5cuw@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/e318fee2-ab72-9d71-6b8b-c99753f4cecc%40gmail.com>
Precedence: bulk


On 7/10/23 7:20 AM, Michael Paquier wrote:
> On Mon, Jul 10, 2023 at 07:05:30AM +0200, Drouvot, Bertrand wrote:
>> Yeah there is one in generate-wait_event_types.pl. I was wondering
>> to add one in wait_event_names.txt too (as this is the place where
>> no wait events would be added if any).
> 
> Hmm.  Something like that could be done, for instance:
> 
>   #   src/backend/utils/activity/wait_event_types.h
> -#      typedef enum definitions for wait events.
> +#      typedef enum definitions for wait events, generated from the first
> +#      field.

Yeah, it looks a good place for it.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com