Message-ID: <e34ab1df-573b-20c1-664a-697851fc736d@gmail.com>
Date: Wed, 5 Apr 2023 14:44:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.1
Subject: Re: Minimal logical decoding on standbys
Content-Language: en-US
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Jeff Davis <pgsql@j-davis.com>,
 Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>,
 Thomas Munro <thomas.munro@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>,
 Amit Khandekar <amitdkhan.pg@gmail.com>, fabriziomello@gmail.com,
 tushar <tushar.ahuja@enterprisedb.com>,
 Rahila Syed <rahila.syed@2ndquadrant.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <ba5aa952-ef8c-b862-69df-0ad9e5d19d23@gmail.com>
 <20230330095449.47yz2q4mn27t6xgl@alvherre.pgsql>
 <CAA4eK1JX-HAmm3TuY=wCSgom+hmiKtkf_xaJLRX9JBo-iXUxHw@mail.gmail.com>
 <CAA4eK1+Tj3B+ODmdRhz7F3fnhang9qEUQatknMuZdi91e=QXeA@mail.gmail.com>
 <68a47e4c-f4bb-45ae-28be-938af60b203c@gmail.com>
 <CAA4eK1L_Zc+7cjm0OhktiPT5xn3=yXn6oenLuEyvJY_CM6T6Mw@mail.gmail.com>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: 
 <CAA4eK1L_Zc+7cjm0OhktiPT5xn3=yXn6oenLuEyvJY_CM6T6Mw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/e34ab1df-573b-20c1-664a-697851fc736d%40gmail.com>
Precedence: bulk

Hi,

On 4/5/23 12:28 PM, Amit Kapila wrote:
> On Wed, Apr 5, 2023 at 2:41 PM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>> Maybe we could change the doc with something among those lines instead?
>>
>> "
>> Existing logical slots on standby also get invalidated if wal_level on primary is reduced to
>> less than 'logical'. This is done as soon as the standby detects such a change in the WAL stream.
>>
>> It means, that for walsenders that are lagging (if any), some WAL records up to the parameter change on the
>> primary won't be decoded".
>>
>> I don't know whether this is what one would expect but that should be less of a surprise if documented.
>>
>> What do you think?
>>
> 
> Yeah, I think it is better to document to avoid any surprises if
> nobody else sees any problem with it.

Ack.

> BTW, another thought that
> crosses my mind is that let's not invalidate the slots when the
> standby startup process processes parameter_change record and rather
> do it when walsender decodes the parameter_change record, if we think
> that is safe. I have shared this as this crosses my mind while
> thinking about this part of the patch and wanted to validate my
> thoughts, we don't need to change even if the idea is valid.
>

I think this is a valid idea but I think I do prefer the current one (where the
startup process triggers the invalidations) because:

   - I think this is better to invalidate as soon as possible. In case of inactive logical
replication slot (walsenders stopped) it could take time to get "notified". While with the current
approach you'd get notified in the logfile and pg_replication_slots even if walsenders are stopped.

   - This is not a "slot" dependent invalidation (as opposed to the xid invalidations case)

   - This is "somehow" the same behavior as on the primary: if one change the wal_level to be < logical
then the engine will not start (if logical slot in place). Then what has been decoded is until the time
the engine has been stopped. So if there is walsender lag, you'd not see some records.

> minor nitpick:
> +
> + /* Intentional fall through to session cancel */
> + /* FALLTHROUGH */
> 
> Do we need to repeat fall through twice in different ways?
> 

Do you mean, you'd prefer what was done in v52/0002?

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com