Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOPMo-0007xI-2H for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Mar 2021 18:33:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lOPMm-0004YW-U1 for pgsql-hackers@arkaria.postgresql.org; Mon, 22 Mar 2021 18:33:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOPMm-0004YN-Ln for pgsql-hackers@lists.postgresql.org; Mon, 22 Mar 2021 18:33:28 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lOPMk-0003uO-OO for pgsql-hackers@postgresql.org; Mon, 22 Mar 2021 18:33:28 +0000 Received: from ip-192-168-0-192.is74.loc (pool-77-222-110-162.is74.ru [77.222.110.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id B2E4E21C60D5; Mon, 22 Mar 2021 21:33:24 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1616438005; bh=/eR7URZLU0liU3pVS4RN4XxIMhgty6MdV459+5Dc5fY=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=gV4TjdjmGpJbMs1xMRSXJjUDNOfJXKegiWQdQydqKY6sUB78gTQ+fbjvfmjDpw3Ll aQ8p86qy3FRi2L8p2WTlAQHDTgiVAk3kaEErodHEmcFAkuAkKu+1suIwa9Y+rEe9Q1 z4+QHKff86GNRUzdpVvYKaubebFOCURyrguPnloU= Subject: Re: [POC] Fast COPY FROM command for the table with foreign partitions To: "tsunakawa.takay@fujitsu.com" , 'Justin Pryzby' Cc: 'Zhihong Yu' , Amit Langote , "tanghy.fnst@fujitsu.com" , Alexey Kondratov , Michael Paquier , Ashutosh Bapat , Ashutosh Bapat , Etsuro Fujita , "pgsql-hackers@postgresql.org" , Tomas Vondra , "houzj.fnst@fujitsu.com" References: <20210214210338.GN1793@telsasoft.com> <20210303202703.GI29832@telsasoft.com> <20210304203949.GQ29832@telsasoft.com> From: Andrey Lepikhov Organization: Postgres Professional Message-ID: Date: Mon, 22 Mar 2021 23:33:23 +0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 5/3/21 21:54, tsunakawa.takay@fujitsu.com wrote: > I've managed to rebased it, although it took unexpectedly long. The patch is attached. It passes make check against core and postgres_fdw. I'll turn the CF status back to ready for committer shortly. Macros _() at the postgresExecForeignCopy routine: if (PQputCopyEnd(conn, OK ? NULL : _("canceled by server")) <= 0) uses gettext. Under linux it is compiled ok, because (as i understood) uses standard implementation of gettext: objdump -t contrib/postgres_fdw/postgres_fdw.so | grep 'gettext' gettext@@GLIBC_2.2.5 but in MacOS (and maybe somewhere else) we need to explicitly link libintl library in the Makefile: SHLIB_LINK += $(filter -lintl, $(LIBS) Also, we may not use gettext at all in this part of the code. -- regards, Andrey Lepikhov Postgres Professional