Feedback-ID: i131946ab:Fastmail
Message-ID: <e3ffb099-6ed8-32b7-21d0-bc950e74b3da@enterprisedb.com>
Date: Fri, 16 Sep 2022 15:54:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.2
Subject: Re: postgres_fdw hint messages
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>,
 Robert Haas <robertmhaas@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: 
 <CA+TgmoY+BuSZm-Fbxx5zC6SuML=2F9YvaYuzVAJ=XyE65BnchQ@mail.gmail.com>
 <1929340.1661531738@sss.pgh.pa.us> <20220901223128.GA932597@nathanxps13>
 <789102.1662073729@sss.pgh.pa.us> <20220901233120.GA934376@nathanxps13>
 <20220902212609.GA1216541@nathanxps13> <YxKn9El8Km/3IZuI@paquier.xyz>
 <1267654.1662170814@sss.pgh.pa.us> <20220903043058.GA1264318@nathanxps13>
 <0fc339d4-3388-3849-4507-ef0fe0c783fa@enterprisedb.com>
 <20220913190255.GA2973985@nathanxps13>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220913190255.GA2973985@nathanxps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e3ffb099-6ed8-32b7-21d0-bc950e74b3da%40enterprisedb.com>
Precedence: bulk

On 13.09.22 21:02, Nathan Bossart wrote:
> On Tue, Sep 13, 2022 at 08:32:43AM +0200, Peter Eisentraut wrote:
>> I notice that for column misspellings, the hint is phrased "Perhaps you
>> meant X." whereas here we have "Did you mean X?".  Let's make that uniform.
> 
> Good point.  I attached a new version of the patch that uses the column
> phrasing.  I wasn't sure whether "reference" was the right word to use in
> this context, but I used it for now for consistency with the column hints.
> I think "specify" or "use" would work as well.

I don't think we need a verb there at all.  I committed it without a verb.