Message-ID: <e4145f77-6f37-40e0-a770-aba359c50b93@enterprisedb.com>
Date: Wed, 6 Mar 2024 18:34:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: logical decoding and replication of sequences, take 2
Content-Language: en-US
To: Dilip Kumar <dilipbalaut@gmail.com>, Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
 "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Masahiko Sawada <sawada.mshk@gmail.com>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
References: <c5e671bc-3400-c2f4-14d3-1ae06c462dad@enterprisedb.com>
 <996e4d3c-648a-46d0-86d2-6465f53ddc58@enterprisedb.com>
 <CA+TgmoaSCu=bLtU7Zyth=h2Lgtzxv=xfRwLYt2ZtSKA=UN2SnQ@mail.gmail.com>
 <5bbadb71-b51e-45a1-9acc-d54f5e8850b6@enterprisedb.com>
 <CA+Tgmoaxertx9iuSeGOoocvq=5GTgZyXZvZBf4w24mQpyz7LRA@mail.gmail.com>
 <241d6c00-7997-480f-80c1-636b28d457cf@enterprisedb.com>
 <CA+TgmobO0eQ2zjekzPZ4s-iTokZ2kEeqAspuyGRyp7qFQQ4g0A@mail.gmail.com>
 <CAFiTN-s7akEaKAHqkw66dL18yW-=oWS20C1SquKsw084qJXBHw@mail.gmail.com>
 <CA+TgmoaZrNz5kb7AcSEFRDJy3yT-86qSNnu+qjs3audyEtq2zA@mail.gmail.com>
 <CAFiTN-syJtrgGAeE=MG5bCAmkzi4QEGPrShkBH7-LgCJfnvB6g@mail.gmail.com>
 <CAFiTN-vBVTbceczNFK29-RFk8v4tXpVbtY5ap76CAjnBm3MtHA@mail.gmail.com>
 <CA+Tgmob+xa-ew4j9HPDdRmqkAs_O8+asEWaxGzeaNn41ro985w@mail.gmail.com>
 <CAFiTN-uhVj-AgVZbPbVPbM8QNz1X9hH7J+3NAo6qYD6VkP_XYw@mail.gmail.com>
 <CA+TgmoYOuSUWxKzXqyBpthb-V36Qv9K9j43JS5txi_YKMavMdA@mail.gmail.com>
 <CAFiTN-t2CStfXiuyjD3=-eEWT+H=PzdvEhAbO3oq0C0LDrc55Q@mail.gmail.com>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: 
 <CAFiTN-t2CStfXiuyjD3=-eEWT+H=PzdvEhAbO3oq0C0LDrc55Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/e4145f77-6f37-40e0-a770-aba359c50b93%40enterprisedb.com>
Precedence: bulk

Hi,

Let me share a bit of an update regarding this patch and PG17. I have
discussed this patch and how to move it forward with a couple hackers
(both within EDB and outside), and my takeaway is that the patch is not
quite baked yet, not enough to make it into PG17 :-(

There are two main reasons / concerns leading to this conclusion:

* correctness of the decoding part

There are (were) doubts about decoding during startup, before the
snapshot gets consistent, when we can get "temporarily incorrect"
decisions whether a change is transactional. While the behavior is
ultimately correct (we treat all changes as non-transactional and
discard it), it seems "dirty" and it’s unclear to me if it might cause
more serious issues down the line (not necessarily bugs, but perhaps
making it harder to implement future changes).

* handling of sequences in built-in replication

Per the patch, sequences need to be added to the publication explicitly.
But there were suggestions we might (should) add certain sequences
automatically - e.g. sequences backing SERIAL/BIGSERIAL columns, etc.
I’m not sure we really want to do that, and so far I assumed we would
start with the manual approach and move to automatic addition in the
future. But the agreement seems to be it would be a pretty significant
"breaking change", and something we probably don’t want to do.


If someone feels has an opinion on either of the two issues (in either
way), I'd like to hear it.


Obviously, I'm not particularly happy about this outcome. And I'm also
somewhat cautious because this patch was already committed+reverted in
PG16 cycle, and doing the same thing in PG17 is not on my wish list.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company