Feedback-ID: ic6394509:Fastmail
MIME-Version: 1.0
Date: Wed, 20 May 2026 04:20:05 -0700
From: "Joel Jacobson" <joel@compiler.org>
To: "Arseniy Mukhin" <arseniy.mukhin.dev@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Message-Id: <e46886ff-4a49-47fb-a76f-3b2f012f1948@app.fastmail.com>
In-Reply-To: 
 <CAE7r3ML+6-pokm+GHsfr+pJyZ_RUi=VY8Bp=qKx=3tcYunborA@mail.gmail.com>
References: <9835b0a4-9121-47ac-9c44-427b8b1a7f1b@app.fastmail.com>
 <CAE7r3ML+6-pokm+GHsfr+pJyZ_RUi=VY8Bp=qKx=3tcYunborA@mail.gmail.com>
Subject: Re: [PATCH] Fix LISTEN startup race with direct advancement
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/e46886ff-4a49-47fb-a76f-3b2f012f1948%40app.fastmail.com>
Precedence: bulk

On Wed, May 20, 2026, at 04:01, Arseniy Mukhin wrote:
> One point - looks like the 0003 contains the same test as 0001.

They are similar, but if you look carefully you'll see that they use
different injection points:

0001 uses async-notify-before-listen-commit
0002 uses async-notify-after-listen-commit

Another different is that if you only apply 0001 and run the tests,
that test will fail without the 0003 fix, whereas 0002 pass both
with and without 0003, since it just tests and demonstrates the
already documented quite harmless false positive race condition.

> Also while I was trying to understand the issue
...
> diagram in the head of the file). It depends on 0001. Your patch fixes
> it too.

OK, I didn't look in detail at untriggered-notification.patch.nocfbot,
but good to hear 0003 fixes it too.

Thanks for reviewing.

/Joel