public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Jeevan Chalke <[email protected]>
To: jian he <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: recently added jsonpath method change jsonb_path_query, jsonb_path_query_first immutability
Date: Sat, 10 Feb 2024 12:24:58 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAM2+6=XVZg1uWEiM_ReTdvWJE4SmPzAjeayNp6uu1E7j4rA__A@mail.gmail.com>
References: <CACJufxFZGhVsAAiTSAi9HOJPJ-bGyG6QkhNmS=mzWHZWxecbng@mail.gmail.com>
<[email protected]>
<CAM2+6=VP-i_gr=14SwQ1XwRSTeUJt8+Y95z2A76XQTzDknQVug@mail.gmail.com>
<CACJufxFcDNqQ44gOhNZG5yGNE7rc7p-EdDXmUqO=AH6tvAhCvA@mail.gmail.com>
<CAM2+6=WH99UnMvaCFXx4WSRrjBQWV02GUXcanPjkx+rQvWJqug@mail.gmail.com>
<CACJufxGtM=z-N9zRtZ9rM079jsh=nnoJ1G-+7W3p9hk1wyAcVA@mail.gmail.com>
<CAM2+6=XVZg1uWEiM_ReTdvWJE4SmPzAjeayNp6uu1E7j4rA__A@mail.gmail.com>
On 2024-02-08 Th 21:02, Jeevan Chalke wrote:
>
>
> On Thu, Feb 8, 2024 at 2:22 PM jian he <[email protected]>
> wrote:
>
> On Thu, Feb 8, 2024 at 1:27 PM Jeevan Chalke
> <[email protected]> wrote:
> >
> >
> >
> > On Wed, Feb 7, 2024 at 9:13 PM jian he
> <[email protected]> wrote:
> >>
> >> On Wed, Feb 7, 2024 at 7:36 PM Jeevan Chalke
> >> <[email protected]> wrote:
> >> > Added checkTimezoneIsUsedForCast() check where ever we are
> casting timezoned to non-timezoned types and vice-versa.
> >>
> >> https://www.postgresql.org/docs/devel/functions-json.html
> >> above Table 9.51. jsonpath Filter Expression Elements, the Note
> >> section, do we also need to rephrase it?
> >
> >
> > OK. Added a line for the same.
> >
>
> diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
> index 6788ba8..37ae2d1 100644
> --- a/doc/src/sgml/func.sgml
> +++ b/doc/src/sgml/func.sgml
> @@ -18240,7 +18240,11 @@ ERROR: jsonpath member accessor can only be
> applied to an object
> <type>timestamptz</type>, and <type>time</type> to
> <type>timetz</type>.
> However, all but the first of these conversions depend on
> the current
> <xref linkend="guc-timezone"/> setting, and thus can only
> be performed
> - within timezone-aware <type>jsonpath</type> functions.
> + within timezone-aware <type>jsonpath</type> functions.
> Similarly, other
> + date/time-related methods that convert string to the
> date/time types
> + also do the casting and may involve the current
> + <xref linkend="guc-timezone"/>. To preserve the
> immutability, those can
> + only be performed within timezone-aware
> <type>jsonpath</type> functions.
> </para>
> </note>
>
> my proposed minor changes:
> - within timezone-aware <type>jsonpath</type> functions.
> + within timezone-aware <type>jsonpath</type> functions.
> Similarly, other
> + date/time-related methods that convert string to the
> date/time types
> + also do the casting and may involve the current
> + <xref linkend="guc-timezone"/> setting. Those conversions can
> + only be performed within timezone-aware
> <type>jsonpath</type> functions.
> I don't have a strong opinion, though.
>
>
> That seems fine as well. Let's leave that to the committer.
>
I edited slightly to my taste, and committed the patch. Thanks.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: recently added jsonpath method change jsonb_path_query, jsonb_path_query_first immutability
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox