Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1grYa4-00072P-4z for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Feb 2019 01:34:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1grYa2-0002px-Lk for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Feb 2019 01:34:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1grYa2-0002pq-Ee for pgsql-hackers@lists.postgresql.org; Thu, 07 Feb 2019 01:34:18 +0000 Received: from mail-yw1-xc2c.google.com ([2607:f8b0:4864:20::c2c]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1grYZz-00080y-MN for pgsql-hackers@postgresql.org; Thu, 07 Feb 2019 01:34:18 +0000 Received: by mail-yw1-xc2c.google.com with SMTP id f65so3982862ywc.8 for ; Wed, 06 Feb 2019 17:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:openpgp:autocrypt:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=8i8yNqOivUWa9RiseIqSVVYtud0g8+xMG3Fjr2fICtM=; b=BllzNtwtZtxpkTu1POscudvktRO0VwlOGUc2ADWi0KmlHLBz94SJ971hL5pIQ2hmdV k1GmmphRxktwIJMZ9umZ3NdpRPDYkUg8ZeuDmRyfY9SkMGnU4yGbvL64uIhClnewbEze Op/S9XTa67MvfJefl9hvJMq5c89tzGADwR6wjuQuDtWtjLjTgOboPnxDz3S/0SMQ7B0E JromDZgOlN6/gxaIG7xd4Hetl+A+RIopH/dIn9U8hStcA0qjE7VC9vEguLaJHKHKahnU AWKc4aTr3Ph9Ag3b/ISTvjowmaR12/Vb6VJhcw01gGYhTp+TtcTEbrjXFpZlyh0VUlL0 glsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:openpgp:autocrypt:message-id :date:user-agent:mime-version:content-transfer-encoding :content-language; bh=8i8yNqOivUWa9RiseIqSVVYtud0g8+xMG3Fjr2fICtM=; b=AoVxWfyQUQfR0c3tcXNW3NmbO6VyCj5vp8sHR7vIdIywD+M56sTwcWyb4x+5LoopWv 9KOtkpWedZ3gNtMZ6newbzuiwzSrchile+vuudCDLQ/02ImQ48g9LG/0VQ6W1DyFJot6 0tr+mqoINtve9Qrdkzb+Q9uYX9e9KB9u8hYGVZugmO7xw3bRfG2Pwysw/YVqTqu4Syh1 yIWDteHlT1xY6gR3lnp6khhAq2TJ0OXc6Z1n3kDXpuXvg8vHPj82IxzpqqDuYS0e34u3 JMQjpAVMbyr+mM9L0A3+G7NM3pqDFbM9SmDazlX0FEspvGI9iF0nMCGmn0EWbQS7v4Yv +i6Q== X-Gm-Message-State: AHQUAuYHfPX1kDJxLw43Sxlk/X7yfo598Oei2MkxsLex1eizwYP4IC+Z d+Wna2SebUF17lQ5jrNAwMb1oAP7CCH689p4R8PiuF+1teP71bWndyQtKZ1V6npRu7447iXM59Y kZtPneIkBCqiIHdk+s3Du/wjWiv0CYWQ4tXxWfkt3q2ta0Ys3NbYEOR94a8q1upRvkKLNPLt15C lm2PUmj7OFfUtJ X-Google-Smtp-Source: AHgI3IbLNgFNd+XAQwWIQFgD00oDaC1x9NYiORoqH5nfSZCV4BHkiS5J8IJ7dfFxliyqtiltFxGH7A== X-Received: by 2002:a81:1b44:: with SMTP id b65mr11137977ywb.393.1549503253261; Wed, 06 Feb 2019 17:34:13 -0800 (PST) Received: from [192.168.10.146] ([98.122.175.38]) by smtp.gmail.com with ESMTPSA id w70sm7214605yww.76.2019.02.06.17.34.12 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 17:34:12 -0800 (PST) From: Andrew Dunstan X-Google-Original-From: Andrew Dunstan To: PostgreSQL-development Subject: Location of pg_rewind/RewindTest.pm and ssl/ServerSetup.pm Openpgp: preference=signencrypt Autocrypt: addr=andrew.dunstan@2ndQuadrant.com; prefer-encrypt=mutual; keydata= xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB AAHNL0FuZHJldyBEdW5zdGFuIDxhbmRyZXcuZHVuc3RhbkAybmRRdWFkcmFudC5jb20+wsCY BBMBAgBCAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUJDyV6hBYhBOQ+WEYd/Hy/RGkV pZn6f8tZ/DuBBQJcH/EVAhkBAAoJEJn6f8tZ/DuB7BEH/iDWZEbVft2m2MT6SPjARzTupt/l xLLZ/Cl6n2US2hov5+fBbnR5xvECk/YCOfG9ICvKNlpFjceqNLRKStd8cmndnI+kDw91uNM2 hpL4aJMeW65XCHvqXlOLSwv5chBpXz9NG7FMaJ+q+59sWEWjcTNmjXgkEHn53y+1pc7nSLDe cr5ZI1aB3nGXRm1SoDY5PYZkUKMykW+YBZwgcs/Q5tRaE+siN7DKbz8E628+PerwAkmHPVXN MdJFD6gs4S0gDFA8IxcyIwZU2v4By+brzcJ9Se3FK5BYxBDHtaYZxgSrJAvOUOrLIZPQTQfL TtnVs3C3JTfrxCH1ceHtnA6dRuTOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oK Waqf+wmW4tpDe/VVcxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7 llV0xSSoFiieQBsrGvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8 BoVrRFcdzlIY/NFNhFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C 4R+M6w7o2PLGOjdZ+kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaY L++LAEOqrlvm2TvqQqZRtnEAEQEAAcLAZQQYAQIADwIbDAUCXA6fpAUJDyV6xAAKCRCZ+n/L Wfw7geU4B/9vFFsVmWxerDWgNjyiK80zIPmlw/iwdUlU6FIu0JWLMg4093kvxBs7RMZV9hBq n3ekBvD4IvFsVLJrw9qzSI2FH3UeYy5WXpEs01Ppia60NOlvRDqXbryzuvfe+iYo6bVP3Ikr TPTNYL/BePUTD2DPvSI82SbGTyzuA7SJv6NRqqQDMIy1fU6KyQFLmQJp/QJyhKWzm9jWh8ee w8jVaoMY0Kbq5N7RqisEx1Lu/Iw646UphdYzQNymf+kbiU5Kf4I6DhzV8w9sie1Bo1juNj3I c5/fFJsmxljbnaDbXPcnFsur1Oo9mIHFakgWgOBMuxoWfjONiLjjLh/9+ZIqSSLX Message-ID: Date: Wed, 6 Feb 2019 20:34:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-MW List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk These two files are used by TAP test suites but fall foul of the tightening of perl's searchpath rules. See for example The obvious solution is to perform the same surgery for the ssl and pg_rewind tests that we performed for genbki.pl and other scripts, but in these cases the used modules are not in the same directory as the using scripts, but in their parent directories. I can't think of a good reason for this.They clearly relate to the TAP test suites, and nothing else, so it seems to me that they should go into the same directory as the TAP test scripts. There should be no danger that "prove" will try to run them, as it is only set up to run files with a ".pl" extension. While we're at it, I think ServerSetup.pm should possibly be renamed to something like SSLServer.pm (and the perl code adjusted accordingly) Does anyone object to me making these changes? cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services